Update MockFactory.php #315
Conversation
| */ | ||
| public function setClient(Client $client) | ||
| public function setClient(HttpClient $client) |
There was a problem hiding this comment.
This is technically a BC break.
But if I understand it correctly. Using this mock factory has never worked, right?
If so, it would mean that this is a bugfix and I'm 👍
|
yes, from my understanding this never actually worked with our bundle configuration. (people might have done something with their own compiler passes, theoretically). also, its only a BC break if you extended the factory, which would be an odd thing to do. i wonder if i should make the factory |
|
Since it's a bug it should be ok, it's only a bc break if anyone extends this factory (since a Mock Client is a HttpClient usage is still BC) so it's rather limited here, we should be fine. Also 👍 for marking this final (and if it's too much of a BC having it as an annotation is fine also) |
dbu
force-pushed
the
allow-decorated-mock-client
branch
from
c56dc73 to
22ad9e3
Compare
dbu
force-pushed
the
allow-decorated-mock-client
branch
from
22ad9e3 to
23e7913
Compare
What's in this PR?
Allow setting any client in the mock factory, to not break when we decorate the client for the debug toolbar.