Mock client doesn't work

[igaponov]

Q	A
Bug?	yes
New Feature?	no
Version	1.10.0

Actual Behavior

Every client is decorated with Http\Client\Common\PluginClient, but \Http\HttplugBundle\ClientFactory\MockFactory::setClient() requires exactly \Http\Mock\Client, this throws an exception

TypeError : Argument 1 passed to Http\HttplugBundle\ClientFactory\MockFactory::setClient() must be an instance of Http\Mock\Client, instance of Http\Client\Common\PluginClient given, called in .../getHttplug_Factory_MockService.php

Expected Behavior

No exception should be thrown.

Steps to Reproduce

Just use the standard config:

# config_test.yml
httplug:
    clients:
        mock:
            factory: 'httplug.factory.mock'

and run any code that uses a client.

Possible Solutions

Probably don't decorate mock client at all?

[Nyholm]

I agree with the solution. But that will result in that we cannot see the client in the profiler toolbar.

[dbu]

could we make the mock factory accept any client? does the factory need to care about what class of client it is, as long as its a client? the factory contract says that it returns a client interface.

[rrajkomar]

Indeed using Http\Client\HttpClient instead of Http\Mock\Client seems the best way to handle this.
Can the fix be expected soon ?
Couldn't help but notice that the bug was reported several months ago. And I could really use it soon, in the meantime I'll try using the MockHandler with guzzle6 .

[dbu]

things happen the fastest when somebody does a pull request ;-)

i did #315 now