Skip to content

Use pretty-ci instead of style-ci #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2018
Merged

Use pretty-ci instead of style-ci #278

merged 2 commits into from
Oct 25, 2018

Conversation

dbu
Copy link
Collaborator

@dbu dbu commented Sep 24, 2018

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #266, replaces #277
Documentation -
License MIT

What's in this PR?

Remove configuration for the styleci php-cs-fixer bridge

Why?

The bridge is abandoned. styleci seems to not offer anything to run codestyle locally with the same configuration as their service. pretty-ci runs exactly php-cs-fixer as a service.

@dbu dbu mentioned this pull request Sep 24, 2018
1 task
@dbu
Copy link
Collaborator Author

dbu commented Sep 24, 2018

if we agree that this is the correct move, i will remove the file from client-common, boilerplate, curl-client, plugins, message, discovery, guzzle6-adapter, mock-client, chache-client and react-adapter.

if we merge this, i will enable pretty-ci for this repo and disable the styleci hooks

@joelwurtz
Copy link
Member

👍 for the move, it avoid us to maintain 2 differents files and I think that a majority of php-http maintainer use php-cs-fixer (at least that's my case)

@dbu dbu requested review from sagikazarmark and Nyholm September 26, 2018 11:42
@dbu
Copy link
Collaborator Author

dbu commented Oct 3, 2018

@sagikazarmark @Nyholm wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP-CS-Fixer not working anymore
2 participants