Skip to content

remove abandoned styleci bridge #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

remove abandoned styleci bridge #277

wants to merge 1 commit into from

Conversation

dbu
Copy link
Collaborator

@dbu dbu commented Sep 23, 2018

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #266
Documentation (not mentioned in the doc)
License MIT

What's in this PR?

Remove configuration for the styleci php-cs-fixer bridge

Why?

The bridge is abandoned. styleci seems to not offer anything to run codestyle locally with the same configuration as their service.
Imho its enough to have the automated check.

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix

@dbu
Copy link
Collaborator Author

dbu commented Sep 23, 2018

if we agree that this is the correct move, i will remove the file from client-common, boilerplate, curl-client, plugins, message, discovery, guzzle6-adapter, mock-client, chache-client and react-adapter.

@Nyholm
Copy link
Member

Nyholm commented Sep 23, 2018

I agree to remove the bridge since it does not work

If we only want to maintain one config file for style, there is Pretty CI by @mnapoli.

@sagikazarmark
Copy link
Member

I agree as well. PrettyCI looks cool, I used FlintCI before, which accepted plain phpcs config, not sure if PrettyCI does.

Can you check if you can disable StyleCI? Do I need to grant some privileges?

@mnapoli
Copy link

mnapoli commented Sep 23, 2018

Hello there! Just answering the question and I'll be out of here: if you want to use it then yes you can use a custom phpcs config, see https://prettyci.com/documentation

@dbu
Copy link
Collaborator Author

dbu commented Sep 24, 2018

see #278

@dbu
Copy link
Collaborator Author

dbu commented Oct 25, 2018

replaced by #278

@dbu dbu closed this Oct 25, 2018
@dbu dbu deleted the cleanup-build-setup branch October 25, 2018 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP-CS-Fixer not working anymore
4 participants