BUG: Fix for to_excel +/- infinity #7949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @@ -122,6 +122,10 @@ cpdef assert_almost_equal(a, b, bint check_less_precise=False): | |||
|
|
|||
| if np.isinf(a): | |||
| assert np.isinf(b), "First object is inf, second isn't" | |||
| if np.isposinf(a): | |||
|
status of this? (did you see my comments above)? |
|
There was an existing test ( |
|
@maxchang ok, makes sense. pls rebase and squash and then I think good to go |
maxchang
force-pushed
the
excel-infinity-fix
branch
from
642057d to
e8830ca
Compare
Previously, a negative sign was being prepended to positive infinite values and was absent for negative infinity. (GH6812) TST: assert_almost_equals() checks +/- infinity The existing ``test_inf_roundtrip`` should have caught this bug, but the underlying ``assert_almost_equal`` was not checking that the two given values were both positive or negative.
maxchang
force-pushed
the
excel-infinity-fix
branch
from
e8830ca to
6644f8b
Compare
|
@jreback Ok, should be ready now. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: Previously, a negative sign was being prepended for positive infinity, not for negative infinity. (GH6812)
xref #6812