BUG/ENH: Fix to_excel representation of inf values #6812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should also handle -inf |
|
@jreback good call - any preference between |
|
I think u should use isinfinite maybe has better platform compat (or may be the same) |
|
Yeah, realized that after I said it haha |
|
okay, that's done. |
|
ok looks fine side note - this formatting to excel space should be done by blocks - would make it much faster (but separate issue) |
|
that's a good point. - let's accept this for now (along with the extra tests to spec out inf) and then we can go back to that later on. |
jtratner
added a commit
that referenced
this pull request
Apr 5, 2014
BUG/ENH: Fix to_excel representation of inf values
| if self.float_format is not None and com.is_float(val): | ||
| val = float(self.float_format % val) | ||
| elif com.is_float(val): | ||
| if np.isposinf(val): |
There was a problem hiding this comment.
Looks like -inf is being written for positive infinite values and vice versa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6782 by converting inf values to string (default is
'inf').This still round trips successfully. According to Stack Overflow post I
found, there isn't a specific representation of
INFvalues -http://stackoverflow.com/questions/15704538/how-can-i-express-nan-values-in-excel
so we're going to make the decision for the writers. This also
(implicitly) fixes an issues where round-tripping an Excel file with an
inf value would cause an
OverflowErrorand fail to read back.cc @jmcnamara and @arthurgerigk-rocket