-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
CI/TST: Use tmp_path for excel test #57516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
53f7f13
Revert "CI: Run excel tests on single cpu for windows (#57486)"
mroeschke 85b7b2c
Use tmp_path fixture
mroeschke b5e5991
uuid4?
mroeschke 063ce56
Merge remote-tracking branch 'upstream/main' into ci/excel
mroeschke ff50907
Merge branch 'ci/excel' of https://github.com/mroeschke/pandas into c…
mroeschke 6351f98
Merge remote-tracking branch 'upstream/main' into ci/excel
mroeschke 8e8594d
Don't remove, pytest cleans itself up eventually
mroeschke f42d2f0
Merge remote-tracking branch 'upstream/main' into ci/excel
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this fixture just for excel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think our Excel code is picky about checking the file extension and hence if/how
ext
is defined in our tests. I think in the general case this won't matter but there might be a better way to generalize how this is set up in our Excel tests?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Not a blocker by any means