CI/TST: Use tmp_path for excel test #57516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 9c02050.
WillAyd
reviewed
Feb 20, 2024
|
|
||
| @pytest.fixture | ||
| def ext(): | ||
| return ".ods" | ||
|
|
||
|
|
||
| def test_write_append_mode_raises(ext): | ||
| @pytest.fixture | ||
| def tmp_excel(ext, tmp_path): |
There was a problem hiding this comment.
Why is this fixture just for excel?
There was a problem hiding this comment.
I think our Excel code is picky about checking the file extension and hence if/how ext is defined in our tests. I think in the general case this won't matter but there might be a better way to generalize how this is set up in our Excel tests?
There was a problem hiding this comment.
Sounds good. Not a blocker by any means
WillAyd
approved these changes
Feb 20, 2024
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* Revert "CI: Run excel tests on single cpu for windows (pandas-dev#57486)" This reverts commit 9c02050. * Use tmp_path fixture * uuid4? * Don't remove, pytest cleans itself up eventually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tm.ensure_cleandoesn't ensure files are unique if the same name is passed, buttmp_pathensures a test gets a unique temp path.