Skip to content

Add test case for applying a function to a groupby object that append… #53138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 9, 2023
Merged

Add test case for applying a function to a groupby object that append… #53138

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ee9e2fd
Add test case for applying a function to a groupby object that append…
May 8, 2023
39daefa
installed pre-commit
idor980 May 8, 2023
b2f9d79
Merge branch 'main' into my-first-branch
idor980 May 8, 2023
b700c83
update expected_value
idor980 May 8, 2023
b586013
Merge branch 'my-first-branch' of https://github.com/idor980/pandas i…
idor980 May 8, 2023
1a0b18a
update expected and installed pre-commit
idor980 May 8, 2023
06c9aec
test commit
idor980 May 8, 2023
cdc0e8f
Merge remote-tracking branch 'upstream/main' into my-first-branch
idor980 May 8, 2023
4252074
committing update for expected value from my last verified commit
idor980 May 8, 2023
24b3e27
Merge remote-tracking branch 'upstream/main' into new-test-branch
idor980 May 8, 2023
23ff56d
Merge branch 'new-test-branch' into my-first-branch
idor980 May 9, 2023
fd2f721
update expected_value to pd.DataFrame({index: [0] * 10, 0: [1] * 10}…
idor980 May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions pandas/tests/groupby/test_apply.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,23 @@
from pandas.tests.groupby import get_groupby_method_args


def test_apply_func_that_appends_group_to_list_without_copy():
# GH: 17718

df = DataFrame(1, index=list(range(10)) * 10, columns=[0]).reset_index()
groups = []

def store(group):
groups.append(group)

df.groupby("index").apply(store)
expected_value = DataFrame(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make expected equal to

DataFrame({"index": [0] * 10, 0: [1] * 10}, index=np.arange(0, 100, 10))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make expected equal to

DataFrame({"index": [0] * 10, 0: [1] * 10}, index=np.arange(0, 100, 10))

No Problem ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make expected equal to

DataFrame({"index": [0] * 10, 0: [1] * 10}, index=np.arange(0, 100, 10))

Is it ok that I used pd.RangeIndex instead of np.arange? I got an error about dtypes and pd.RangeIndex fixed it

{"index": [0] * 10, 0: [1] * 10}, index=pd.RangeIndex(0, 100, 10)
)

tm.assert_frame_equal(groups[0], expected_value)


def test_apply_issues():
# GH 5788

Expand Down