Add test case for applying a function to a groupby object that append… #53138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s each group to a list without using copy() function. The test checks if the groups are correctly appended to the list. This resolves GH issue 17718.
srkds
reviewed
May 8, 2023
There was a problem hiding this comment.
Hi,
Some checks are failing because of the formatting of the code.
here is the documentation for pre-commit.
Could you install it and then commit again?
OK, thank you :) |
mroeschke
reviewed
May 8, 2023
| groups.append(group) | ||
|
|
||
| df.groupby("index").apply(store) | ||
| expected_value = DataFrame( |
There was a problem hiding this comment.
Could you make expected equal to
DataFrame({"index": [0] * 10, 0: [1] * 10}, index=np.arange(0, 100, 10))
There was a problem hiding this comment.
Could you make
expectedequal toDataFrame({"index": [0] * 10, 0: [1] * 10}, index=np.arange(0, 100, 10))
No Problem ;)
There was a problem hiding this comment.
Could you make
expectedequal toDataFrame({"index": [0] * 10, 0: [1] * 10}, index=np.arange(0, 100, 10))
Is it ok that I used pd.RangeIndex instead of np.arange? I got an error about dtypes and pd.RangeIndex fixed it
…nto my-first-branch
… index=pd.RangeIndex(0, 100, step=10))
mroeschke
approved these changes
May 9, 2023
|
Thanks @idor980 |
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
pandas-dev#53138) * Add test case for applying a function to a groupby object that appends each group to a list without using copy() function. The test checks if the groups are correctly appended to the list. This resolves GH issue 17718. * installed pre-commit * update expected_value * update expected and installed pre-commit * test commit * committing update for expected value from my last verified commit * update expected_value to pd.DataFrame({index: [0] * 10, 0: [1] * 10}, index=pd.RangeIndex(0, 100, step=10)) --------- Co-authored-by: Ido Ronen <idor98@Idos-MacBook-Pro.local>
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
pandas-dev#53138) * Add test case for applying a function to a groupby object that appends each group to a list without using copy() function. The test checks if the groups are correctly appended to the list. This resolves GH issue 17718. * installed pre-commit * update expected_value * update expected and installed pre-commit * test commit * committing update for expected value from my last verified commit * update expected_value to pd.DataFrame({index: [0] * 10, 0: [1] * 10}, index=pd.RangeIndex(0, 100, step=10)) --------- Co-authored-by: Ido Ronen <idor98@Idos-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s each group to a list without using copy() function. The test checks if the groups are correctly appended to the list. This resolves GH issue 17718.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.