BUG: Index with duplicate labels raises ValueError in Dataframe.query

[steliospetrakis02]

• closes BUG: Index with duplicate labels raises ValueError in Dataframe.query #51815
• Tests added and passed if fixing a bug or adding a new feature
• All code checks passed.
• Added type annotations to new arguments/methods/functions.
• Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

[mroeschke]

The fix should not require a new method on the DataFrame

[steliospetrakis02]

Hey @mroeschke , just wanted to give you a quick update on my progress. I've integrated the latest version of my code into the 'query()' function, which should help streamline the overall process. Let me know if you have any questions or concerns.

[steliospetrakis02]

Hello @mroeschke, I have made modifications to the query() function to check for duplicate index labels, but some tests have failed. As a new contributor to this open-source project, I would appreciate your expert opinion on whether I should make further changes to the code or focus on fixing the failing tests.

[mroeschke]

As a new contributor to this open-source project

Honestly, I would suggest tackling an issue label good first issue first rather than this bug. A fix should ideally not fail existing tests and the solution should not involve falling back to a try/except

[steliospetrakis02]

Hello @mroeschke , I'm not sure if you saw, but I have made changes to the implementation. It no longer requires falling back to a try/except. Instead, I added an if statement to check for duplicate indexes.It covers all the constraints that you have informed me of, and it is currently working.

if self.index.duplicated().any():
engine='numexpr'
# Create a copy of the dataframe with a unique index to avoid reindexing errors
unique_index = RangeIndex(len(self.index))
df_copy = self.copy()
df_copy.index = unique_index

        # Filter the copied dataframe
        filtered_df = df_copy.query(expr, engine=engine)

        # Map the filtered index back to the original index labels
        index_mapping = dict(zip(unique_index, self.index))
        filtered_df.index = filtered_df.index.map(index_mapping)
        
        return filtered_df

I apologize for the frequent comments, I don't mean to be a bother.

[github-actions]

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

[mroeschke]

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.