-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
CLN: Remove 3rd party warning filters #50674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
37908b3
CLN: Remove 3rd party warning filers
mroeschke c56dd87
Merge remote-tracking branch 'upstream/main' into cln/old_warnings
mroeschke 3220a56
Move 3rd party warnings to pyproject.toml, some comments
mroeschke 3d43d48
Move 3rd party warnings to pyproject.toml, some comments
mroeschke 92d0560
Merge remote-tracking branch 'upstream/main' into cln/old_warnings
mroeschke 8c0e0ed
Merge remote-tracking branch 'upstream/main' into cln/old_warnings
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +0,0 @@ | ||
import pytest | ||
|
||
pytestmark = [ | ||
# fastparquet | ||
pytest.mark.filterwarnings( | ||
"ignore:PY_SSIZE_T_CLEAN will be required.*:DeprecationWarning" | ||
), | ||
pytest.mark.filterwarnings( | ||
r"ignore:`np\.bool` is a deprecated alias:DeprecationWarning" | ||
), | ||
# xlrd | ||
pytest.mark.filterwarnings( | ||
"ignore:This method will be removed in future versions:DeprecationWarning" | ||
), | ||
pytest.mark.filterwarnings( | ||
"ignore:This method will be removed in future versions. " | ||
r"Use 'tree.iter\(\)' or 'list\(tree.iter\(\)\)' instead." | ||
":PendingDeprecationWarning" | ||
), | ||
] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +0,0 @@ | ||
import pytest | ||
|
||
pytestmark = [ | ||
pytest.mark.filterwarnings( | ||
# Looks like tree.getiterator is deprecated in favor of tree.iter | ||
"ignore:This method will be removed in future versions:" | ||
"PendingDeprecationWarning" | ||
), | ||
pytest.mark.filterwarnings( | ||
"ignore:This method will be removed in future versions:DeprecationWarning" | ||
), | ||
] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +0,0 @@ | ||
import pytest | ||
|
||
pytestmark = [ | ||
# pytables https://github.com/PyTables/PyTables/issues/822 | ||
pytest.mark.filterwarnings( | ||
"ignore:a closed node found in the registry:UserWarning" | ||
), | ||
pytest.mark.filterwarnings( | ||
r"ignore:`np\.object` is a deprecated alias.*:DeprecationWarning" | ||
), | ||
pytest.mark.filterwarnings( | ||
r"ignore:`np\.bool` is a deprecated alias.*:DeprecationWarning" | ||
), | ||
] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +0,0 @@ | ||
import pytest | ||
|
||
pytestmark = [ | ||
# 2021-02-01 needed until numba updates their usage | ||
pytest.mark.filterwarnings( | ||
r"ignore:`np\.int` is a deprecated alias:DeprecationWarning" | ||
), | ||
] | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment on where this comes from and maybe condition under which we can stop filtering? (im guessing numpy>x.y.z)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC I don't think there's necessarily a version timeline of when deprecation warnings are enforced (unless that's in scope of numpy 2.0?) cc @seberg
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ummm, not sure I want to tie cleaning out all deprecations to NumPy 2.0, but I guess it is safe. If it helps, you can also put 1.25 and I will just do it, heh...
(We need to clean up expired deprecations a bit more systematically...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I'll just note that it will be changing in 1.25 so we can maybe be more proactive in changing this behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did it for 1.25/main, thanks.