CLN: Remove 3rd party warning filters #50674
Conversation
mroeschke
added
Testing
mroeschke
changed the title
pandas/tests/frame/test_unary.py
Outdated
| ), | ||
| pd.DataFrame({"a": np.array([-1, 2], dtype=object)}), | ||
| pd.DataFrame({"a": [Decimal("-1.0"), Decimal("2.0")]}), | ||
| ], | ||
| ) | ||
| def test_pos_object(self, df): | ||
| # GH#21380 | ||
| # GH#21380F |
| @@ -101,14 +101,16 @@ def test_pos_numeric(self, df): | |||
| # numpy changing behavior in the future | |||
| pytest.param( | |||
| pd.DataFrame({"a": ["a", "b"]}), | |||
| marks=[pytest.mark.filterwarnings("ignore")], | |||
| marks=[ | |||
| pytest.mark.filterwarnings("ignore:Applying:DeprecationWarning") | |||
There was a problem hiding this comment.
comment on where this comes from and maybe condition under which we can stop filtering? (im guessing numpy>x.y.z)
There was a problem hiding this comment.
IIUC I don't think there's necessarily a version timeline of when deprecation warnings are enforced (unless that's in scope of numpy 2.0?) cc @seberg
There was a problem hiding this comment.
Ummm, not sure I want to tie cleaning out all deprecations to NumPy 2.0, but I guess it is safe. If it helps, you can also put 1.25 and I will just do it, heh...
(We need to clean up expired deprecations a bit more systematically...)
There was a problem hiding this comment.
Okay I'll just note that it will be changing in 1.25 so we can maybe be more proactive in changing this behavior
There was a problem hiding this comment.
Just did it for 1.25/main, thanks.
* CLN: Remove 3rd party warning filers * Move 3rd party warnings to pyproject.toml, some comments * Move 3rd party warnings to pyproject.toml, some comments
Checking if any of these are still needed and if so probably moving them to pyproject.toml