Skip to content

CLN: remove deprecated DEF #47936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 8, 2022
Merged

CLN: remove deprecated DEF #47936

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7bdd555
CLN: remove deprecated DEF
fangchenli Aug 3, 2022
4b4cc04
Merge remote-tracking branch 'upstream/main' into remove-deprecated-DEF
fangchenli Aug 3, 2022
38545da
fix empty line
fangchenli Aug 3, 2022
1841bff
Merge remote-tracking branch 'upstream/main' into remove-deprecated-DEF
fangchenli Aug 4, 2022
1b9f7b6
move consts inside of func
fangchenli Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pandas/_libs/hashing.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ import_array()

from pandas._libs.util cimport is_nan

DEF cROUNDS = 2
DEF dROUNDS = 4


@cython.boundscheck(False)
def hash_object_array(
Expand Down Expand Up @@ -162,6 +159,8 @@ cdef uint64_t low_level_siphash(uint8_t* data, size_t datalen,
cdef uint8_t* end = data + datalen - (datalen % sizeof(uint64_t))
cdef int left = datalen & 7
cdef int left_byte
cdef int cROUNDS = 2
cdef int dROUNDS = 4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any upside to assigning this at the module level?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any in this case.


b = (<uint64_t>datalen) << 56
v3 ^= k1
Expand Down