CLN: remove deprecated DEF #47936
Merged
CLN: remove deprecated DEF #47936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzeitlin11
reviewed
Aug 3, 2022
mzeitlin11
approved these changes
Aug 4, 2022
jbrockmendel
reviewed
Aug 4, 2022
| @@ -162,6 +159,8 @@ cdef uint64_t low_level_siphash(uint8_t* data, size_t datalen, | |||
| cdef uint8_t* end = data + datalen - (datalen % sizeof(uint64_t)) | |||
| cdef int left = datalen & 7 | |||
| cdef int left_byte | |||
| cdef int cROUNDS = 2 | |||
| cdef int dROUNDS = 4 | |||
There was a problem hiding this comment.
is there any upside to assigning this at the module level?
There was a problem hiding this comment.
I don't see any in this case.
mroeschke
approved these changes
Aug 8, 2022
|
Thanks @fangchenli |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* CLN: remove deprecated DEF * fix empty line * move consts inside of func
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref cython/cython#4310
discovered in #47442