Skip to content

REF: extract more functions in pandas/core/describe.py #39170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

ivanovmg
Copy link
Member

Extracted describe_series, describe_frame and select_column in pandas/core/describe.py.
The next time I think I will introduce the classes SeriesDescriber and DataFrameDescriber and will start moving the functions into the methods incrementally, if that is OK.

@ivanovmg ivanovmg requested a review from jreback January 14, 2021 16:22
@jreback jreback added the Refactor Internal refactoring of code label Jan 14, 2021
@jreback jreback added this to the 1.3 milestone Jan 14, 2021
@jreback jreback merged commit 008b10b into pandas-dev:master Jan 14, 2021
@jreback
Copy link
Contributor

jreback commented Jan 14, 2021

yep looks good @ivanovmg

@ivanovmg ivanovmg deleted the refactor/describe branch January 15, 2021 10:16
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants