34297 sub slow in first call #34354
Merged
34297 sub slow in first call #34354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
May 24, 2020
jreback
requested changes
May 25, 2020
jreback
added
Benchmark
Added the whats new entry. |
� Conflicts: � doc/source/whatsnew/v1.1.0.rst
jreback
requested changes
May 26, 2020
asv_bench/benchmarks/arithmetic.py
Outdated
| columns=column_names, | ||
| ) | ||
|
|
||
| def time_sub_multiindex(self, func): |
There was a problem hiding this comment.
can you rename to: time_binary_op_multiindex
jreback
approved these changes
May 26, 2020
|
thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff@jbrockmendel
I added a lenght check as suggested by you. I could not find another method to check the indices (nlevels for example does not work). I'm open to recommendations about adding additional checks before running into the values call.
I have added a test, which measures the execution time of both calls to
sub. Is there a better way to test, if they are equally fast?