REF: collect casting portion of Block.setitem #32940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Mar 24, 2020
| assert not is_dtype_equal(self.dtype, dtype) | ||
| # otherwise should have _can_hold_element | ||
|
|
||
| return self.astype(dtype).setitem(indexer, value) |
There was a problem hiding this comment.
do we do copy=False internally in .astype?
There was a problem hiding this comment.
That's the default kwarg for Block.astype, yes
jreback
added
Dtype Conversions
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block.setitem is sometimes inplace and sometimes casts/copies. The idea here is to isolate the casting cases and eventually separate them into their own method, so we can be more careful about when we call the inplace vs not-inplace setters.