-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
PERF: Improve duplicated perf #13751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
self.int.duplicated() | ||
|
||
def time_float_duplicated(self): | ||
self.int.duplicated() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
int -> float
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks. re-submit a bench:)
Current coverage is 84.58% (diff: 100%)@@ master #13751 diff @@
==========================================
Files 141 141
Lines 51233 51258 +25
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43331 43356 +25
Misses 7902 7902
Partials 0 0
|
Updated the bench. |
7646463
to
2f53f67
Compare
cdef: | ||
Py_ssize_t i, n | ||
dict seen = dict() | ||
object row |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can use templates for these (make another issue)
git diff upstream/master | flake8 --diff
Index/Series.duplicated
now uses dtype-based logic. Also skip algorithm ifIndex.is_unique
isTrue
(expected to be cached in practical situation).asv:
NOTE: can create template for htable after #13716.