Skip to content

Added Timestamp to Series#__getitem__ #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 19, 2023
Merged

Added Timestamp to Series#__getitem__ #775

merged 6 commits into from
Sep 19, 2023

Conversation

GarrisonD
Copy link
Contributor

Closes #773

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also appears our CI is failing for unrelated reasons, so I need to investigate that and fix it. Probably a versioning issue.

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Sep 18, 2023

We need to get #776 approved and merged, then you remerge with main, then I can run the tests.

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Sep 18, 2023

@GarrisonD can you merge with main and push, then I will fire off the CI, as the issue with that has been fixed.

@GarrisonD
Copy link
Contributor Author

@Dr-Irv Sure, will do tomorrow.

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Sep 19, 2023

@GarrisonD CI failing. The check line should be check(assert_type(series[index[-1]], int), np.integer) Sorry for misleading you

@GarrisonD
Copy link
Contributor Author

Can I move this check to https://github.com/pandas-dev/pandas-stubs/pull/775/files#diff-ea813cbfeb870b2b17f19af553004745162233003506303a2a577e86da7a5836R994 and in my test just have series[index[-1]] that will be checked by mypy/pyright?

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Sep 19, 2023

Can I move this check to https://github.com/pandas-dev/pandas-stubs/pull/775/files#diff-ea813cbfeb870b2b17f19af553004745162233003506303a2a577e86da7a5836R994 and in my test just have series[index[-1]] that will be checked by mypy/pyright?

Merging your test function with the one above would have been fine, but we do want to try using check(assert_type(... in new tests. I'm going to approve/merge this in now because it passed our tests.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @GarrisonD

@Dr-Irv Dr-Irv merged commit b7d23a5 into pandas-dev:main Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Series#__getitem__ doesn't accept pd.Timestamp
3 participants