Skip to content

Commit b7d23a5

Browse files
authored
Added Timestamp to Series#__getitem__ (#775)
* Added `Timestamp` to `Series#__getitem__` #773 * Fixed code review comments * Replaced `int | _str` with `Scalar` * Removed `Timestamp` (it's included in `Scalar`) * Fixed failing tests by replacing `int` with `np.integer`
1 parent 7e6f8a9 commit b7d23a5

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

pandas-stubs/core/series.pyi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@ class Series(IndexOpsMixin[S1], NDFrame):
360360
| tuple[Hashable | slice, ...],
361361
) -> Self: ...
362362
@overload
363-
def __getitem__(self, idx: int | _str) -> S1: ...
363+
def __getitem__(self, idx: Scalar) -> S1: ...
364364
def __setitem__(self, key, value) -> None: ...
365365
def repeat(
366366
self, repeats: int | list[int], axis: AxisIndex | None = ...

tests/test_series.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -999,6 +999,12 @@ def test_types_getitem() -> None:
999999
s3: pd.Series = s[:2]
10001000

10011001

1002+
def test_types_getitem_by_timestamp() -> None:
1003+
index = pd.date_range("2018-01-01", periods=2, freq="D")
1004+
series = pd.Series(range(2), index=index)
1005+
check(assert_type(series[index[-1]], int), np.integer)
1006+
1007+
10021008
def test_types_eq() -> None:
10031009
s1 = pd.Series([1, 2, 3])
10041010
res1: pd.Series = s1 == 1

0 commit comments

Comments
 (0)