Owls 103828 - Fix for the Cluster and Domain 'Available' conditions for admin only domains and intentionally shutdown clusters #3602

ankedia · 2022-11-01T17:11:54Z

Owls 103828 - Fix for the Cluster and Domain 'Available' Conditions for admin only domains and intentionally shutdown clusters. In addition, it contains fix for Completed:false for domain with NEVER policy. This PR includes changes from the PR # 3597 (OWLS-103825 branch).

Set Cluster 'Available' Condition to false if no servers expected to run.
Set Domain 'Available' Condition to true if only admin server is running and cluster(s) and managed servers are intentionally shutdown.
Set Domain Completed Condition to true if domain start policy is NEVER.

Integration test run - https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/13685/console

…no servers expected to run.

…ssed with Lenny.

alai8 · 2022-11-01T17:42:19Z

@ankedia @lennyphan Does this PR include all the changes from PR 3597 for OWLS-103825? Do we still need PR 3597?

lennyphan · 2022-11-01T17:46:41Z

@ankedia @lennyphan Does this PR include all the changes from PR 3597 for OWLS-103825? Do we still need PR 3597?

This PR includes the changes from PR 3597. We made a conflicting change so decided it was best to resolve both JIRA's in one PR, if possible.

tbarnes-us · 2022-11-01T18:24:55Z

Please also update the doc to something similar to what we discussed in the Slack...

#### `Available` {id="cluster-available"}
- The `status` attribute is set to `True` when a sufficient number of WebLogic Server pods are
  ready in the cluster. Both of the following must be true:
  - At least one pod in the cluster is expected to run and is `ready`.
  - The number of `not ready` server pods which are expected to run
    is less than or equal to `cluster.spec.maxUnavailable` which defaults to `1`.
- Examples:
  - If a cluster has `serverStartPolicy` `Never` or `replicas` `0`,
    or a cluster is in a domain with `serverStartPolicy` `AdminOnly` or `Never`,
    then the cluster will have `Available` `False`.
  - If a cluster and domain both have a `serverStartPolicy` of `IfNeeded`,
    and `cluster.spec.replicas` is `1`,
    then the cluster `Available` will be `True` only when its single pod is `ready`. 
  - If a cluster and domain both have a `serverStartPolicy` of `IfNeeded`,
    `cluster.spec.replicas` is `4`,
    and `cluster.spec.maxUnavailable` is `1` (the default),
    then the cluster `Available` will be `True` only when three are four of its pods are `ready`. 
- **Note**: The `Available` `status` can be `True` even when the `status` for the `Completed`
  condition is `False`, a `Failed` condition is reported on the Domain resource, or the cluster
  has up to `cluster.spec.maxUnavailable` pods that are not ready.

…oc changes.

documentation/staging/content/managing-domains/accessing-the-domain/status-conditions.md

tbarnes-us · 2022-11-01T21:36:12Z

The doc update LGTM.

alai8

LGTM. Please update PR comment with Never serverStartPolicy related changes. Also, please ask Rosemary to review the doc change. Thanks.

Updated. @rosemarymarano - please review the doc changes.

sonarqubecloud · 2022-11-01T21:43:03Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

93.1% Coverage
0.0% Duplication

rosemarymarano

review edits and suggestions

rosemarymarano · 2022-11-02T11:04:54Z

documentation/staging/content/managing-domains/accessing-the-domain/status-conditions.md

+- The `status` attribute is set to `True` when a sufficient number of WebLogic Server pods are
+  ready in the cluster. Both of the following must be true:
+  - At least one pod in the cluster is expected to run and is `ready`.
+  - The number of `not ready` server pods which are expected to run


pods which are expected to run -> pods, which are expected to run, (two commas needed)

rosemarymarano · 2022-11-02T11:11:15Z

documentation/staging/content/managing-domains/accessing-the-domain/status-conditions.md

+  ready in the cluster. Both of the following must be true:
+  - At least one pod in the cluster is expected to run and is `ready`.
+  - The number of `not ready` server pods which are expected to run
+    is less than or equal to `cluster.spec.maxUnavailable` which defaults to `1`.


is less than or equal to cluster.spec.maxUnavailable, which defaults to 1. -> (at a minimum, you need a comma before the word "which')
If you want to make it more explicit, then consider this wording -> is less than or equal to the value of cluster.spec.maxUnavailable, which defaults to 1.

rosemarymarano · 2022-11-02T11:20:15Z

documentation/staging/content/managing-domains/accessing-the-domain/status-conditions.md

+- Examples:
+  - If a cluster has `serverStartPolicy` `Never` or `replicas` `0`,
+    or a cluster is in a domain with `serverStartPolicy` `AdminOnly` or `Never`,
+    then the cluster will have `Available` `False`.


Re-write (I can hardly understand the meaning of this sentence, but here's a stab at it): If a cluster has a serverStartPolicy of Never, (comma) or replicas is 0, or a cluster is in a domain with a serverStartPolicy of AdminOnly or Never, (comma) then the cluster will be Available, False.

…or admin only domains and intentionally shutdown clusters (oracle#3602) * Fix for the Cluster and Domain 'Available' conditions for admin only domains and intentionally shutdown clusters Co-authored-by: Lenny Phan <lenny.phan@oracle.com>

…or admin only domains and intentionally shutdown clusters (#3602) * Fix for the Cluster and Domain 'Available' conditions for admin only domains and intentionally shutdown clusters Co-authored-by: Lenny Phan <lenny.phan@oracle.com>

lennyphan and others added 7 commits October 31, 2022 17:42

check Domain Status servers to see if admin server only

a54d759

Identify admin server status by comparing server name

f8caa67

rename method

d3eb72b

OWLS-103828 - WKO 4.0: Set Cluster 'Available' Condition to false if …

1a4ff8d

…no servers expected to run.

Merge remote-tracking branch 'origin/OWLS-103825' into owls_103828

6f0ca59

Merge changes from OWLS-103825 branch and additional changes as discu…

f5b93fa

…ssed with Lenny.

Fix unit test names.

5353805

ankedia requested review from russgold, alai8, rjeberhard, tbarnes-us, doxiao and lennyphan November 1, 2022 17:11

oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 1, 2022

lennyphan mentioned this pull request Nov 1, 2022

OWLS-103825: Available should be true for admin server only domain #3597

Closed

Fix for completed condition for Domains with NEVER start policy and d…

b395c9d

…oc changes.

alai8 reviewed Nov 1, 2022

View reviewed changes

documentation/staging/content/managing-domains/accessing-the-domain/status-conditions.md Outdated Show resolved Hide resolved

Fix the typo as per the review comment.

db92d4a

rjeberhard approved these changes Nov 1, 2022

View reviewed changes

rjeberhard requested a review from rosemarymarano November 1, 2022 21:36

alai8 approved these changes Nov 1, 2022

View reviewed changes

alai8 requested review from rosemarymarano and removed request for rosemarymarano November 1, 2022 21:37

lennyphan approved these changes Nov 1, 2022

View reviewed changes

rjeberhard merged commit 83846b3 into main Nov 1, 2022

rosemarymarano reviewed Nov 2, 2022

View reviewed changes

rjeberhard deleted the owls_103828 branch February 18, 2023 14:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Owls 103828 - Fix for the Cluster and Domain 'Available' conditions for admin only domains and intentionally shutdown clusters #3602

Owls 103828 - Fix for the Cluster and Domain 'Available' conditions for admin only domains and intentionally shutdown clusters #3602

Uh oh!

ankedia commented Nov 1, 2022 •

edited

Loading

Uh oh!

alai8 commented Nov 1, 2022

Uh oh!

lennyphan commented Nov 1, 2022

Uh oh!

tbarnes-us commented Nov 1, 2022 •

edited

Loading

Uh oh!

Uh oh!

tbarnes-us commented Nov 1, 2022

Uh oh!

alai8 left a comment •

edited by ankedia

Loading

Uh oh!

sonarqubecloud bot commented Nov 1, 2022

Uh oh!

rosemarymarano left a comment

Uh oh!

rosemarymarano Nov 2, 2022

Uh oh!

rosemarymarano Nov 2, 2022 •

edited

Loading

Uh oh!

rosemarymarano Nov 2, 2022

Uh oh!

Uh oh!

Owls 103828 - Fix for the Cluster and Domain 'Available' conditions for admin only domains and intentionally shutdown clusters #3602

Owls 103828 - Fix for the Cluster and Domain 'Available' conditions for admin only domains and intentionally shutdown clusters #3602

Uh oh!

Conversation

ankedia commented Nov 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alai8 commented Nov 1, 2022

Uh oh!

lennyphan commented Nov 1, 2022

Uh oh!

tbarnes-us commented Nov 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

tbarnes-us commented Nov 1, 2022

Uh oh!

alai8 left a comment • edited by ankedia Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Nov 1, 2022

Uh oh!

rosemarymarano left a comment

Choose a reason for hiding this comment

Uh oh!

rosemarymarano Nov 2, 2022

Choose a reason for hiding this comment

Uh oh!

rosemarymarano Nov 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rosemarymarano Nov 2, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ankedia commented Nov 1, 2022 •

edited

Loading

tbarnes-us commented Nov 1, 2022 •

edited

Loading

alai8 left a comment •

edited by ankedia

Loading

rosemarymarano Nov 2, 2022 •

edited

Loading