OWLS-103825: Available should be true for admin server only domain #3597
Conversation
lennyphan
requested review from
russgold,
alai8,
rjeberhard,
tbarnes-us,
doxiao and
ankedia
oracle-contributor-agreement
bot
added
the
OCA Verified
|
Kudos, SonarCloud Quality Gate passed! |
| @@ -857,13 +857,23 @@ private Collection<DomainPresenceInfo.ServerStartupInfo> getServerStartupInfos() | |||
|
|
|||
| // when the domain start policy is ADMIN_ONLY, the admin server is considered to be an application server. | |||
There was a problem hiding this comment.
The comment is bit misleading after the change.
Domain Available and Complete should both stay True in this case. The Domain Status Conditions Complete & Available are supposed to ignore clusters that aren't supposed to be running. Note that Domain and Cluster Status Complete may "blip" false while the Cluster is partway through shutting down - as Complete is supposed to be false if shutdowns are not finished. |
| return getDomain().getSpec().getServerStartPolicy() == ServerStartPolicy.ADMIN_ONLY; | ||
| } | ||
|
|
||
| private boolean isOnlyAdminServerRunningInDomain() { | ||
| return status.getServers().size() == 1 |
There was a problem hiding this comment.
I think this doesn't take into account the servers or clusters that have been intentioanlly shut down.
|
Closing this PR as it has been combined with PR 3602 |
Condition Available will be true for a Domain where the only server configured to run is the Admin server.