Skip to content
This repository was archived by the owner on May 28, 2021. It is now read-only.

Properly exclude the local instance from the seeds list #131

Merged
merged 1 commit into from
Jun 26, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/controllers/cluster/manager/innodb_cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ func getReplicationGroupSeeds(seeds string, pod *cluster.Instance) ([]string, er
if err != nil {
return nil, err
}
if seedInstance.PodName() == pod.Name() {
if seedInstance.Name() == pod.Name() {
continue
}
s = append(s, seed)
Expand Down
4 changes: 2 additions & 2 deletions pkg/controllers/cluster/manager/innodb_cluster_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ func TestGetReplicationGroupSeeds(t *testing.T) {
{
seeds: "server-1-0:1234,server-1-1:1234",
pod: cluster.NewInstance("", "", "server-1", 0, -1, false),
expected: []string{"server-1-0:1234", "server-1-1:1234"},
expected: []string{"server-1-1:1234"},
}, {
seeds: "server-1-1:1234,server-1-0:1234",
pod: cluster.NewInstance("", "", "server-1", 0, -1, false),
expected: []string{"server-1-1:1234", "server-1-0:1234"},
expected: []string{"server-1-1:1234"},
}, {
seeds: "server-1-0:1234,server-1-1:1234",
pod: cluster.NewInstance("", "", "server-2", 0, -1, false),
Expand Down