This repository was archived by the owner on May 28, 2021. It is now read-only.
Properly exclude the local instance from the seeds list #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianlucaborello
changed the title
prydie
added
the
oracle-cla: no
Signed-off-by: Gianluca Borello <g.borello@gmail.com>
gianlucaborello
force-pushed
the
exclude-self-from-seeds
branch
from
8441506 to
edb96aa
Compare
owainlewis
added
oracle-cla: yes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Not sure if this is the proper fix, but while testing this I noticed that the local instance is never excluded from the seed list, because we are comparing
Instance.Name()withInstance.PodName(), which never leads to the same results, at least in my experiments.Since the comment on top of the
getReplicationGroupSeedsfunction saysIt removes the local instance of mysql from the group, it seems a reasonable fix to do.The updated tests also reflect the logic of excluding the local instance from the seed.
At the moment I'm hesitant to sign the Oracle CLA, I make this commit under the Apache License 2.0, feel free to use it as is, or also just report the changes in your own commit, I don't mind. Please let me know if it's going to be a problem.
Thanks