This repository was archived by the owner on May 28, 2021. It is now read-only.
Independent mysql-agent ClusterRole and RBAC #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separates the mysql-operator and mysql-agent ClusterRoles and scopes the RBAC to the minimal permissions required by each.
owainlewis
reviewed
Jun 1, 2018
| @@ -29,12 +27,11 @@ import ( | |||
| ) | |||
|
|
|||
| // StatefulSetControlInterface defines the interface that the | |||
| // MySQLClusterController uses to create, update, and delete StatefulSets. It | |||
| // MySQLClusterController uses to create and update StatefulSets. It | |||
There was a problem hiding this comment.
MySQLClusterController uses [this interface] to create
owainlewis
reviewed
Jun 1, 2018
| @@ -29,12 +27,11 @@ import ( | |||
| ) | |||
|
|
|||
| // StatefulSetControlInterface defines the interface that the | |||
| // MySQLClusterController uses to create, update, and delete StatefulSets. It | |||
| // MySQLClusterController uses to create and update StatefulSets. It | |||
| // is implemented as an interface to enable testing. | |||
| type StatefulSetControlInterface interface { | |||
| CreateStatefulSet(ss *apps.StatefulSet) error | |||
There was a problem hiding this comment.
Ideally we'd rename CreateStatefulSet to align with the name changes to PatchStatefulSet below i.e.
m.statefulSetControl.Patch
m.statefulSetControl.Create(...)
There was a problem hiding this comment.
I’m actually planning a follow on to remove all the control interfaces and just use the client directly. With the fake client we don’t need the interfaces for testing and they just add a bunch of complexity and indirection.
owainlewis
approved these changes
Jun 1, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates the
mysql-operatorandmysql-agentClusterRoles and scopes the RBAC to the minimal permissions required by each.Changelog