This repository was archived by the owner on May 28, 2021. It is now read-only.
Fix RBAC by making more restrictive #113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owainlewis
changed the title
owainlewis
commented
May 24, 2018
| resources: | ||
| - secrets | ||
| verbs: | ||
| - get |
There was a problem hiding this comment.
This is a problem when cluster scoped. Can we remove this one?
prydie
reviewed
May 24, 2018
| verbs: | ||
| - get | ||
| - create | ||
| - delete |
prydie
reviewed
May 24, 2018
| - list | ||
| - watch | ||
| - create | ||
| - delete |
prydie
reviewed
May 24, 2018
| @@ -19,11 +19,67 @@ metadata: | |||
| namespace: {{ .Values.operator.namespace}}{{ end }} | |||
| rules: | |||
There was a problem hiding this comment.
We need two ClusterRoles: mysql-agent and mysql-operator as the components require different permissions (principle of least privilege).
We need a ServiceAccount mysql-operator and corresponding ClusterRoleBinding in the namespace into which the operator is being installed.
Users must create a ServiceAccount mysql-agent and RoleBinding to the ClusterRole mysql-agnet in each namespace they want to deploy clusters. We should not create this in the default namespace automatically but rather document the requirement clearly.
|
Closing in favour of #121 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change locks down RBAC rules for the mysql-operator service account. In future we might want a separate service account for the operator and agent.