Skip to content

feat: improved per resource polling #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 27, 2023
Merged

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Mar 22, 2023

No description provided.

@csviri csviri self-assigned this Mar 22, 2023
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@csviri csviri marked this pull request as ready for review March 22, 2023 14:30
@csviri csviri requested a review from metacosm March 22, 2023 14:30
@@ -26,14 +27,17 @@
* @param <R> the resource polled by the event source
* @param <P> related custom resource
*/
// todo check docs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@csviri csviri requested a review from metacosm March 27, 2023 06:53
@csviri csviri force-pushed the improved-per-resource-polling branch from 88da314 to 7899339 Compare March 27, 2023 10:11
@csviri csviri changed the base branch from next to main March 27, 2023 10:11
@csviri csviri force-pushed the improved-per-resource-polling branch from 7899339 to ba3710c Compare March 27, 2023 10:20
@csviri csviri changed the base branch from main to next March 27, 2023 10:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

39.1% 39.1% Coverage
0.0% 0.0% Duplication

@csviri csviri merged commit 3751a68 into next Mar 27, 2023
@csviri csviri deleted the improved-per-resource-polling branch March 27, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to configure subsequent poll delay for PerResourcePollingEventSource
2 participants