feat: warn if zip is too large, and log the largest files #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
ascorbic
force-pushed
the
feat/zip-size-warning
branch
from
9a1d993 to
9fffa23
Compare
lindsaylevine
approved these changes
Oct 21, 2021
ascorbic
force-pushed
the
feat/zip-size-warning
branch
from
9d3dde7 to
8217972
Compare
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Errors when trying to upload lambdas are common, and are usually the result of accidentally bundling a large dependency such as electron or chromium. The error message is cryptic and not actionable for users. This PR adds a post-build check on the size of the zip. If it's larger than 50MB (the documented max compressed size) it logs some helpful(?) information. It also lists the 10 largest files in the zip, which should help in diagnosing the problem. In most cases the problem is a single module.
It would benefit from having some docs, which we can add a shortlink to. If we merge #728 then we could add info there about enabling the feature that moves the files outside the bundle.
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal (small picture)