Skip to content

chore: update docs for repo standards #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

lukeocodes
Copy link

few little bits in here. lmk what you think

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Jul 15, 2021

We'd love to hear from you! So, if you have any questions, comments, or bugs, let us know! You can either:

- Open an issue on this repository

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is kindof related to my comment above about the questions section

promote a positive and inclusive environment.
* **Use a clear and descriptive title** for the issue to identify the problem.
* **Describe the exact steps which reproduce the problem** in as many details as possible. When listing steps, **don't just say what you did, but explain how you did it**.
* **Provide specific examples to demonstrate the steps**. Include links to files or GitHub projects, or copy/pasteable snippets, which you use in those examples. If you're providing snippets in the issue, use [Markdown code blocks](https://help.github.com/articles/markdown-basics/#multiple-lines).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not that many people will read this in depth vs the github issue template, but we prob do want to emphasize that simple repos that reproduce the issue are preferred, and simple means anyone can clone and deploy (aka no api keys, no db setup, etc)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would make sense to have a full doc on how to do this actually, akin to this one from Gatsby, and include a field in an issue form specifically with a link to the repro

@@ -0,0 +1,19 @@
### Requirements for Contributing Documentation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use issue forms instead of templates?

promote a positive and inclusive environment.
* **Use a clear and descriptive title** for the issue to identify the problem.
* **Describe the exact steps which reproduce the problem** in as many details as possible. When listing steps, **don't just say what you did, but explain how you did it**.
* **Provide specific examples to demonstrate the steps**. Include links to files or GitHub projects, or copy/pasteable snippets, which you use in those examples. If you're providing snippets in the issue, use [Markdown code blocks](https://help.github.com/articles/markdown-basics/#multiple-lines).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would make sense to have a full doc on how to do this actually, akin to this one from Gatsby, and include a field in an issue form specifically with a link to the repro

CONTRIBUTING.md Outdated
* Place requires in the following order:
* Built in Node Modules (such as `path`)
* Other NPM Installed Node Modules (such as `fs-extra`)
* Local Modules (using relative paths)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is all enforced by eslint. We can just say that they need to run the format command.

CONTRIBUTING.md Outdated

1. Merge the release PR
2. Run `npm publish`
* Use [Markdown](https://daringfireball.net/projects/markdown).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to link to the gfm docs

@lukeocodes lukeocodes self-assigned this Aug 11, 2021
@tiffafoo
Copy link

Closing this cuz I guess it's old

@tiffafoo tiffafoo closed this Nov 24, 2021
serhalp added a commit that referenced this pull request Jun 13, 2024
* gh issues to failure list

* add token

* add based on file name or test name

* add comments

* Update tools/deno/ghIssues2json.ts

Co-authored-by: Philippe Serhal <philippe.serhal@netlify.com>

* return empty arr if no match

* allow for multi test names

* add schedule

* fix multi name setup

* Update tools/deno/ghIssues2json.ts

Co-authored-by: Philippe Serhal <philippe.serhal@netlify.com>

* Update tools/deno/ghIssues2json.ts

Co-authored-by: Philippe Serhal <philippe.serhal@netlify.com>

* chore: format with prettier

---------

Co-authored-by: Philippe Serhal <philippe.serhal@netlify.com>
Co-authored-by: taty2010 <taty2010@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants