Skip to content

Fix deprecated method #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Fix deprecated method #31

merged 1 commit into from
Nov 13, 2020

Conversation

ehmicky
Copy link

@ehmicky ehmicky commented Nov 13, 2020

Fixes #30.

fs.exists() is deprecated.
We should use alternatives such as path-exists instead.

@ehmicky ehmicky added the type: bug code to address defects in shipped code label Nov 13, 2020
@ehmicky ehmicky self-assigned this Nov 13, 2020
Copy link

@lindsaylevine lindsaylevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted!!

@ehmicky ehmicky merged commit 5ed516f into main Nov 13, 2020
@ehmicky ehmicky deleted the bug/exists branch November 13, 2020 18:37
@ehmicky
Copy link
Author

ehmicky commented Nov 13, 2020

To be fair, considering how careful Node.js is about breaking changes, it is possible this deprecated method will never be removed :D

ascorbic pushed a commit that referenced this pull request Oct 4, 2021
Co-authored-by: Renovate Bot <bot@renovateapp.com>
serhalp pushed a commit that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove usage of deprecated fs.exists()
2 participants