Skip to content

feat: add generator meta data for framework generated Netlify Functions #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 22, 2023

Conversation

taty2010
Copy link
Contributor

@taty2010 taty2010 commented Mar 17, 2023

Summary

This update creates a metadata file that will allow us to update the naming of our generated functions within the UI and will help us keep track of the nextjs-runtime versions being used.

We ran into some errors within the previous PR that were seemingly unrelated to our changes and transferred everything over.
Prev: #1973

closes https://github.com/netlify/pod-ecosystem-frameworks/issues/407
closes https://github.com/netlify/pod-ecosystem-frameworks/issues/376

Test plan

Netlify UI test

  1. Within the Netlify UI go to the demo site and go to the Functions tab
  2. In the Functions search bar enter 1999 for the repo
  3. Should see Next.js SSR handler, Next.js ISR handler, and next/image handler

Version test

  1. Should be able to see the version being returned within Humio

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@netlify
Copy link

netlify bot commented Mar 17, 2023

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit bc7b5a6
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/641b5fbadb19e20008366439
😎 Deploy Preview https://deploy-preview-1999--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 17, 2023

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit bc7b5a6
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/641b5fba5f47c70008368f48
😎 Deploy Preview https://deploy-preview-1999--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Mar 17, 2023
@netlify
Copy link

netlify bot commented Mar 17, 2023

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit bc7b5a6
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/641b5fba2875ae0008968c5f
😎 Deploy Preview https://deploy-preview-1999--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 17, 2023

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit bc7b5a6
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/641b5fbac983500008dd6cb0
😎 Deploy Preview https://deploy-preview-1999--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 17, 2023

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit bc7b5a6
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/641b5fbae5b8ef00082b249e
😎 Deploy Preview https://deploy-preview-1999--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 17, 2023

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit bc7b5a6
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/641b5fbadb19e2000836643e
😎 Deploy Preview https://deploy-preview-1999--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 17, 2023

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit bc7b5a6
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/641b5fba21b8c200086578bd
😎 Deploy Preview https://deploy-preview-1999--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 17, 2023

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit bc7b5a6
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/641b5fba4cce4e000928f3de
😎 Deploy Preview https://deploy-preview-1999--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 17, 2023

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit bc7b5a6
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/641b5fbab91e5700083de0d8
😎 Deploy Preview https://deploy-preview-1999--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@taty2010 taty2010 changed the title fix: moving functionmetadata over feat: add generator meta data for framework generated Netlify Functions Mar 17, 2023
@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Mar 17, 2023
@taty2010 taty2010 marked this pull request as ready for review March 17, 2023 20:44
@taty2010 taty2010 requested a review from a team March 17, 2023 20:44
@kodiakhq kodiakhq bot merged commit e5ddcd2 into main Mar 22, 2023
@kodiakhq kodiakhq bot deleted the tn/generator-test branch March 22, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: bug code to address defects in shipped code type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants