Skip to content

feat: add generator meta data for framework generated Netlify Functions #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 28 commits into from
Closed

feat: add generator meta data for framework generated Netlify Functions #1973

wants to merge 28 commits into from

Conversation

taty2010
Copy link
Contributor

@taty2010 taty2010 commented Mar 9, 2023 •
edited
Loading

Summary

https://github.com/netlify/pod-ecosystem-frameworks/issues/407

Test plan

  1. Visit the Deploy Preview (insert link to specific page) ...

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@netlify
Copy link

netlify bot commented Mar 9, 2023 •
edited
Loading

❌ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo failed.

Name Link
🔨 Latest commit 60d15af
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/6414be36076111000838b840

@netlify
Copy link

netlify bot commented Mar 9, 2023 •
edited
Loading

❌ Deploy Preview for netlify-plugin-nextjs-static-root-demo failed.

Name Link
🔨 Latest commit 60d15af
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/6414be364851190007938e86

@netlify
Copy link

netlify bot commented Mar 9, 2023 •
edited
Loading

❌ Deploy Preview for next-plugin-edge-middleware failed.

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/6414c1077aee3b22ac8bb75c

@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Mar 9, 2023
@netlify
Copy link

netlify bot commented Mar 9, 2023 •
edited
Loading

❌ Deploy Preview for nextjs-plugin-custom-routes-demo failed.

Name Link
🔨 Latest commit 60d15af
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/6414be36c5921d0008e0e195

@netlify
Copy link

netlify bot commented Mar 9, 2023 •
edited
Loading

❌ Deploy Preview for next-plugin-canary failed.

Name Link
🔨 Latest commit 60d15af
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/6414be3663cd9b0008d22068

@netlify
Copy link

netlify bot commented Mar 9, 2023 •
edited
Loading

❌ Deploy Preview for next-i18next-demo failed.

Name Link
🔨 Latest commit 60d15af
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/6414be36717a5b00088bca6c

@netlify
Copy link

netlify bot commented Mar 9, 2023 •
edited
Loading

❌ Deploy Preview for netlify-plugin-nextjs-demo failed.

Name Link
🔨 Latest commit 60d15af
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/6414be36039e580008ad3e1b

@netlify
Copy link

netlify bot commented Mar 9, 2023 •
edited
Loading

❌ Deploy Preview for netlify-plugin-nextjs-export-demo failed.

Name Link
🔨 Latest commit 60d15af
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/6414be3682a8580008ae90ba

@netlify
Copy link

netlify bot commented Mar 9, 2023 •
edited
Loading

❌ Deploy Preview for netlify-plugin-nextjs-next-auth-demo failed.

Name Link
🔨 Latest commit 60d15af
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/6414be36961a5c0007241214

@taty2010 taty2010 self-assigned this Mar 9, 2023
MarcL
MarcL reviewed Mar 10, 2023
View reviewed changes
MarcL
MarcL reviewed Mar 10, 2023
View reviewed changes
@nickytonline nickytonline changed the title feat: Generator for Serverless Functions feat: add generator meta data for framework generated Netlify Functions Mar 15, 2023
@nickytonline nickytonline force-pushed the tn/generator-serverless branch from 6a57201 to db3051f Compare March 16, 2023 21:39
@nickytonline nickytonline force-pushed the tn/generator-serverless branch from ed4ec93 to 93db1c3 Compare March 17, 2023 01:49
@nickytonline nickytonline force-pushed the tn/generator-serverless branch from 93db1c3 to 3021f37 Compare March 17, 2023 01:51
MarcL
MarcL reviewed Mar 17, 2023
View reviewed changes
MarcL
MarcL reviewed Mar 17, 2023
View reviewed changes
MarcL
MarcL reviewed Mar 17, 2023
View reviewed changes
MarcL
MarcL reviewed Mar 17, 2023
View reviewed changes
@taty2010 taty2010 mentioned this pull request Mar 17, 2023
Merged
2 tasks
@nickytonline
Copy link

Closing in favour of #1999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickytonline nickytonline nickytonline left review comments

@MarcL MarcL MarcL left review comments

Assignees

@taty2010 taty2010

Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taty2010 @nickytonline @MarcL