Skip to content

chore: update to 13.0.0 #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demos/base-path/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"typescript": "^4.6.3"
},
"dependencies": {
"next": "^12.3.2-canary.43"
"next": "^13.0.0"
},
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
Expand Down
9 changes: 4 additions & 5 deletions demos/canary/netlify.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,12 @@ command = "next build"
publish = ".next"
ignore = "if [ $CACHED_COMMIT_REF == $COMMIT_REF ]; then (exit 1); else git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF ../..; fi;"

[build.environment]
TERM = "xterm"
NODE_VERSION = "17"

[[plugins]]
package = "../plugin-wrapper/"
package = "@netlify/plugin-nextjs"
Copy link

@nickytonline nickytonline Oct 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we're not using the plugin wrapper anymore only in the Canary site? Or is that because it's 12.x for the moment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are (see below in the diff). The reason we have the plugin included by name as well is to prevent build auto-installing the release version (like you had happen). The wrapper now doesn;t actually export anything, it just ensures the monorepo is built. "@netlify/plugin-nextjs" is resolved to the one in the monorepo.


# This is a fake plugin, that makes it run npm install
[[plugins]]
package = "@netlify/plugin-local-install-core"

[[plugins]]
package = "../plugin-wrapper"
340 changes: 173 additions & 167 deletions demos/canary/package-lock.json

Large diffs are not rendered by default.

12 changes: 10 additions & 2 deletions demos/canary/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,19 @@
"lint": "next lint"
},
"dependencies": {
"next": "^12.2.0",
"next": "^12.3.1",
"react": "18.1.0",
"react-dom": "18.1.0"
},
"devDependencies": {
"eslint": "8.22.0"
"@netlify/plugin-nextjs": "*",
"@types/fs-extra": "^9.0.13",
"@types/jest": "^27.4.1",
"@types/node": "^17.0.25",
"critters": "^0.0.16",
"husky": "^7.0.4",
"if-env": "^1.0.4",
"npm-run-all": "^4.1.5",
"typescript": "^4.6.3"
}
}
2 changes: 1 addition & 1 deletion demos/custom-routes/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"typescript": "^4.7.4"
},
"dependencies": {
"next": "^12.3.2-canary.43"
"next": "^13.0.0"
},
"scripts": {
"build": "next build",
Expand Down
2 changes: 1 addition & 1 deletion demos/default/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"@reach/dialog": "^0.16.2",
"@reach/visually-hidden": "^0.16.0",
"@vercel/og": "^0.0.15",
"next": "^12.3.2-canary.43",
"next": "^13.0.0",
"react": "^18.0.0",
"react-dom": "^18.0.0"
},
Expand Down
2 changes: 1 addition & 1 deletion demos/middleware/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"dependencies": {
"@netlify/next": "*",
"@netlify/plugin-nextjs": "*",
"next": "^12.3.2-canary.43",
"next": "^13.0.0",
"react": "18.0.0",
"react-dom": "18.0.0"
},
Expand Down
2 changes: 1 addition & 1 deletion demos/next-auth/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
],
"license": "MIT",
"dependencies": {
"next": "^12.3.2-canary.43",
"next": "^13.0.0",
"next-auth": "^4.15.0",
"nodemailer": "^6.6.3",
"react": "^18.0.0",
Expand Down
2 changes: 1 addition & 1 deletion demos/next-export/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"description": "",
"dependencies": {
"next": "^12.3.2-canary.43"
"next": "^13.0.0"
},
"devDependencies": {
"@netlify/plugin-nextjs": "*",
Expand Down
Loading