Skip to content

chore: update to 13.0.0 #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2022
Merged

chore: update to 13.0.0 #1717

merged 2 commits into from
Oct 26, 2022

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Oct 26, 2022

Summary

Updates the demos to use 13.0.0 now that it is out, rather than the final canary version. Also temporarily updates the canary demo site to use 12.x instead, so we can test that it still works with the old version.

Test plan

  1. Ensure the test sites build

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

lots of capybaras on an underwater tandem

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@netlify
Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit 3a383ef
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/6359056766b1ea0008fb1351
😎 Deploy Preview https://deploy-preview-1717--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit 3a383ef
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/63590567f65e090008210df4
😎 Deploy Preview https://deploy-preview-1717--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Oct 26, 2022
@netlify
Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/635a8bab26902931db8a23e2
😎 Deploy Preview https://deploy-preview-1717--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit 3a383ef
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/635905675fe6fe0009339826
😎 Deploy Preview https://deploy-preview-1717--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit 3a383ef
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/6359056766b1ea0008fb1356
😎 Deploy Preview https://deploy-preview-1717--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit 3a383ef
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/63590567067e0400080d6f85
😎 Deploy Preview https://deploy-preview-1717--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit 3a383ef
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/63590567067e0400080d6f8a
😎 Deploy Preview https://deploy-preview-1717--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit 3a383ef
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/63590568669fa70008d48c91
😎 Deploy Preview https://deploy-preview-1717--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit 3a383ef
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/63590567189b7d00090facd3
😎 Deploy Preview https://deploy-preview-1717--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ascorbic ascorbic marked this pull request as ready for review October 26, 2022 10:29
@ascorbic ascorbic requested a review from a team October 26, 2022 10:29
[[plugins]]
package = "../plugin-wrapper/"
package = "@netlify/plugin-nextjs"
Copy link

@nickytonline nickytonline Oct 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we're not using the plugin wrapper anymore only in the Canary site? Or is that because it's 12.x for the moment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are (see below in the diff). The reason we have the plugin included by name as well is to prevent build auto-installing the release version (like you had happen). The wrapper now doesn;t actually export anything, it just ensures the monorepo is built. "@netlify/plugin-nextjs" is resolved to the one in the monorepo.

Copy link

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kodiakhq kodiakhq bot merged commit 04bcac0 into main Oct 26, 2022
@kodiakhq kodiakhq bot deleted the mk/update-next-13 branch October 26, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants