Skip to content

Add pkg-config support #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2014
Merged

Add pkg-config support #42

merged 1 commit into from
Sep 14, 2014

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Sep 14, 2014

Resolves #18

cdunn2001 added a commit that referenced this pull request Sep 14, 2014
@cdunn2001 cdunn2001 merged commit dd5b57a into open-source-parsers:master Sep 14, 2014
@cdunn2001
Copy link
Contributor

Thanks!

@jplatte
Copy link
Contributor Author

jplatte commented Sep 14, 2014

No problem :)

I now realized that it's not complete though. I tested the generation but not the usage and the pkg-config file is missing a "Version" definition. If I knew how to get the version number in CMake, I could easily create another small patch, but I don't find anything concerning versioning in CMakeLists.txt.

@cdunn2001
Copy link
Contributor

If you think it's worthwhile, you can recover part of the CMake rules for the version-string from a few commits back, where I deleted it. I certainly don't mind a version string in header files or pkg-config, but it must not confuse the revision-control system. The problem was that people were running amalgamate.py before running cmake, so they lacked the generated version.h file. But if only cmake generates the pkg-config, then it's fine.

@jplatte
Copy link
Contributor Author

jplatte commented Sep 15, 2014

For the .pc file, the version string is mandatory (I accidentaly used another incomplete file as template), so it would be needed for pkg-config support. I don't know what amalgamate.py is though. It's up to you to decide what to do...

On a related note: When testing the installation of jsoncpp, I saw a jsoncpp.so.SOVERSION being installed, which obviously seems wrong. Should I create a seperate issue for this or do you know what this is about and you're able to fix it when recovering the version information in CMake?

@cdunn2001
Copy link
Contributor

SOVERSION might be related to the SONAME problem in issue #43.

@cdunn2001
Copy link
Contributor

JSONCPP_VERSION and JSONCPP_VERSION_MAJOR are now available. (See #44.) I don't know which you want. Feel free to update your pkg-config template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add pkg-config file
2 participants