refacto: buffer management, setup fixes, autocmd fixes #967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 12, 2022
Buffer management rewritten to be completely wiped out when closing the view. Buffer is properly intanciated when needed. The setup autocmd have been a bit cleaned up, less indirections. Renamed update_to_buf_dir to hijack_directories wich makes more sense. Sessions with a tree buffer will open with the tree (without the state saved). Also added ability to open with a path like `:NvimTreeOpen /some/dir`. Renamed view.win_open to view.is_visible. Started to make a proper api for the view, to avoid mutating the internals from the outside (and thus leaking abstractions to the callers).
fixes lazy loading
Allows not initializing nvim-tree at all during setup which should make startup time better for people not using the open_on_setup or not opening on directory.
also run find_file when preventing buffer override
kyazdani42
force-pushed
the
refacto/rewrite-buffer-management
branch
from
870ac07 to
48818d5
Compare
|
Just tested this branch, at least the intro screen (#193) works as expected, thanks for fixing so quickly! |
|
Can confirm that the error on #965 doesn't happen anymore. Thanks for the hard work! |
|
merging this then, there might new issues coming up, will see :) The codebase will soon be in a state where testing might become a reality 😄 |
|
Errors occur after this merge.
|
|
Same here, every time I open a file this error occurs. |
|
reinstalled plugin, not seeing the errors anymore. |
|
not sure, but i forgot to guard the diagnostic code against the tree not being initialized (which can happen). I just pushed a fix this morning. |
Almo7aya
pushed a commit
to Almo7aya/nvim-tree.lua
that referenced
this pull request
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer management rewritten to be completely wiped out when closing the view.
Buffer is properly intanciated when needed.
Started to make a proper api for the view, to avoid mutating the internals from the outside (and thus leaking abstractions to the callers).
The autocmds have been a bit cleaned up, less indirections.
Renamed
update_to_buf_dirtohijack_directorieswich makes more sense.Sessions with a tree buffer will open with the tree (without the state saved).
Also added ability to open with a path like
:NvimTreeOpen /some/dir.Renamed
view.win_opentoview.is_visible(BREAKING).Doesn't load the directory on setup when not needed, which should improve startuptime.
Fixes #601
Fixes #488
Fixes #965
Fixes #238 (possible to setup
open_on_setuptofalseandhijack_directorieswith auto open and enable totruewill do this behavior)Fixes #502
Fixes #193
Fixes #592
And maybe even more issues could be closed.
Please people tagged in these issue, try this PR and confirm it works well.