Skip to content

add option to make width a percentage of "&columns" #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2021
Merged

add option to make width a percentage of "&columns" #473

merged 3 commits into from
Jun 30, 2021

Conversation

booperlv
Copy link
Contributor

Allows nvim_tree_width to accept a string, that will determine whether or not it's a percentage of width of entire editor in columns.
Following @sindrets proposal from the previous pull request.

@booperlv booperlv closed this Jun 29, 2021
@booperlv
Copy link
Contributor Author

Facepalm did the same mistake again. I am very sorry - first time actually doing anything on github other than messing around with my own repo. Reopening this.

@booperlv booperlv reopened this Jun 29, 2021
@sindrets
Copy link
Contributor

No worries, we've all been through this at some point:)

@booperlv booperlv requested a review from kyazdani42 June 30, 2021 03:54
@booperlv booperlv requested a review from kyazdani42 June 30, 2021 19:24
@booperlv
Copy link
Contributor Author

Assuming this is all good now, Should I cleanup the commit history before it gets merged?

Copy link
Member

@kyazdani42 kyazdani42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ;)

@kyazdani42 kyazdani42 merged commit d311c22 into nvim-tree:master Jun 30, 2021
Almo7aya pushed a commit to Almo7aya/nvim-tree.lua that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants