-
-
Notifications
You must be signed in to change notification settings - Fork 625
add option to use width as percentage #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the feature, a few formatting issues to fix before merging :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes and please add documentation for the option
Sorry for the odd code, whipped this up as a quick fix while on a break from other projects. |
One more question by the way, Where do you think it would be best to place the option in the documentation? Would right under g:nvim_tree_width be better or is it good as is right now? |
Some thoughts: do we really need another option for this? Seems really unnecessary. Can we not just make it so that let g:nvim_tree_width = 30 " indicates width of 30 columns.
let g:nvim_tree_width = '30%' " indicates width of 30% of '&columns'. |
That is very reasonable. |
agreed with sindrets proposal, looks better this way :) |
alright, going to start working on it :) |
Opened a new pull request ( #473 ) with the suggested changes, both because I think it's different, and because I messed up resetting the fork's master branch and ended up deleting the fork. The more I learn about git and not messing around with it at 2AM. Closing this one now :D |
adds option to use nvim_tree_width as a percentage (reads the width as a percentage and converts to decimal, multiply to vim total columns)