1221 handle deprecated vert split

[alex-courtis]

closes #1221

• detect WinSeparator, falls back to VertSplit
• NvimTreeWinSeparator defaults to NvimTreeVertSplit

We could put a warning about this deprecation however I do not think it is worth it.

[alex-courtis]

This is fine. WinSeparator defaults to VertSplit in 0.7.0.

[alex-courtis]

@siduck please test.

[alex-courtis]

Not sure why there were no NvimTree prefixes. We can revert.

[kyazdani42]

I think it was because i've specified the original groups, but it doesn't matter too much, i actually think it's clearer this way

[siduck]

@siduck please test.

works as expected

[alex-courtis]

Thank you.

[par4m]

This works just fine, this might be unrelated but i can't figure out whats causing the horizontal split to go out of bounds, any idea?

[siduck]

This works just fine, this might be unrelated but i can't figure out whats causing the horizontal split to go out of bounds, any idea?

this seems like an upstream issue and I get it only when a horizontal splt's touching nvimtree.

[alex-courtis]

this seems like an upstream issue and I get it only when a horizontal splt's touching nvimtree.

Could you try and replicate that without nvim-tree?

[siduck]

this seems like an upstream issue and I get it only when a horizontal splt's touching nvimtree.

Could you try and replicate that without nvim-tree?

with nvim-tree

without nvimtree

[adastx]

All works fine for me except for the horizontal splt's touching nvimtree as mentioned by the others.

Sidenote: any idea how to get some more padding on the number row when using number and relative number? There's almost no space between the current line number and nvim-tree for example.
Edit: set signcolumn=yes

[siduck]

numberwidth option ig

[alex-courtis]

All works fine for me except for the horizontal splt's touching nvimtree as mentioned by the others.

That is a possible nvim-tree problem. I cannot replicate with the minimal config and :hi NvimTreeVertSplit guibg=#ff0000 guifg=#00FF00. I can see that there is a lot of customisation and probably plugins in your setup.

@siduck @adastx : please produce a minimal configuration that demonstrates this issue so that we may replicate: raise a new bug report and put your minimal configuration in there.

[siduck]

@alex-courtis

[siduck]

Steps to reproduce @alex-courtis

git clone --depth 1 https://github.com/wbthomason/packer.nvim\
 ~/.local/share/nvim/site/pack/packer/start/packer.nvim

init.lua

vim.opt.laststatus= 3
vim.opt.termguicolors = true

vim.cmd "hi Normal guibg=#000000"
vim.cmd "hi NvimTreeNormal guibg=#ffffff guifg=#000000"

vim.cmd "hi WinSeparator guibg='NONE'"
vim.cmd "hi NvimTreeWinSeparator guifg='#ffffff' guibg='#ffffff'"

require("packer").startup {
    {
      "wbthomason/packer.nvim",
      {
              "kyazdani42/nvim-tree.lua",
              branch = "1221-handle-deprecated-VertSplit",
      },
      "kyazdani42/nvim-web-devicons",
    },
 }
require("nvim-tree").setup {}

[alex-courtis]

Steps to reproduce @alex-courtis

Replicated.

This happens on this branch, as well as the previous 86d573d

This might be a neovim bug. We should replicate this without nvim-tree.

[alex-courtis]

Replicated without nvim-tree:

nvim --clean
<C-w>v
<C-w>w
<C-w>s
:set laststatus=3
:hi MyWinSeparator ctermfg=1 ctermbg=2
:setlocal winhl=WinSeparator:MyWinSeparator

I don't know if this is intended behaviour; @siduck please raise a neovim issue.

[siduck]

@alex-courtis yes it is, So this is no longer nvimtree related issue Ig, it'd be great to push the changes for now tho!

[kyazdani42]

good enough for now, once we merge the switch to 0.7, we'll remove this :)