call NvimTreeToggle, Invalid parameter

[tttoad]

Description

When I call NvimTreeToggle, I get an error

Neovim version

NVIM v0.6.1
Build type: Release
LuaJIT 2.1.0-beta3

Operating system and version

macOS 11.2.3

nvim-tree version

86d573d

Steps to reproduce

:NvimTreeToggle

Expected behavior

No response

Actual behavior

No response

Minimal config

-- init.lua
vim.o.ignorecase=true

vim.opt.encoding="UTF-8"
vim.o.number=true
-- 设置行会导致输入指令后乱码...
-- vim.o.lines=60
vim.opt.mouse="a"
vim.o.cursorline=true
vim.opt.laststatus=2
vim.o.autoindent=true
vim.opt.tabstop=4
vim.o.smarttab=true
vim.opt.shiftwidth=4
vim.opt.softtabstop=4
vim.opt.backspace="eol,start,indent"
vim.o.showcmd=true
vim.o.whichwrap=vim.o.whichwrap.."<,>,h,l"
vim.opt.scrolloff=3
vim.opt.history=1000
vim.opt.cmdheight=2


require'nvim-tree'.setup {
}
return require('plugins')

[autosquash]

Same issue in Windows 10, NVIM 0.6.1, default configuration.

[alex-courtis]

The above minimal config does not run. Please provide a full nvt-min.lua as per the bug report so that we can try to reproduce.

[alex-courtis]

Could not replicate with minimal configuration nvim 0.6.1

I've added some logging and the following is being successfully executed:

setlocal winhl=EndOfBuffer:NvimTreeEndOfBuffer,Normal:NvimTreeNormal,CursorLine:NvimTreeCursorLine,WinSeparator:NvimTreeWinSeparator,StatusLine:NvimTreeStatusLine,StatusLineNC:NvimTreeStatuslineNC,SignColumn:NvimTreeSignColumn,NormalNC:NvimTreeNormalNC

I cannot exactly compare this to your error as you have not provided the error text, just a picture.

E474 may be ambiguous without the message. Please can you provide the english translation of the message.

[alex-courtis]

Actions:

@tttoad

• translate the E474 error message it is E474: Invalid argument

@ttoad @gulliver-madrid

• test with a minimal configuration as per bug report
• attempt to execute some of the command via vim command e.g. setlocal winhl=EndOfBuffer:NvimTreeEndOfBuffer, repeating until you receive the error call NvimTreeToggle, Invalid parameter #1221 (comment)

[Marko-Sanchez]

Similar issue when calling :NvimTreeOpen

E5108: Error executing lua ...im/autoload/plugged/nvim-tree.lua/lua/nvim-tree/view.lua:121: Vim(setlocal):E474: Invalid argument: winhl=EndOfBuffer:NvimTreeEndOfBuffer,Normal:NvimTreeNormal,CursorLine:NvimTreeCurs
orLine,WinSeparator:NvimTreeWinSeparator,StatusLine:NvimTreeStatusLine,StatusLineNC:NvimTreeStatuslineNC,SignColumn:NvimTreeSignColumn,NormalNC:NvimTreeNormalNC                                                     
stack traceback:                                                                                                                                                                                                     
        [C]: in function 'cmd'                                                                                                                                                                                       
        ...im/autoload/plugged/nvim-tree.lua/lua/nvim-tree/view.lua:121: in function 'set_local'                                                                                                                     
        ...im/autoload/plugged/nvim-tree.lua/lua/nvim-tree/view.lua:139: in function 'set_window_options_and_buffer'                                                                                                 
        ...im/autoload/plugged/nvim-tree.lua/lua/nvim-tree/view.lua:193: in function 'open'                                                                                                                          
        ...vim/autoload/plugged/nvim-tree.lua/lua/nvim-tree/lib.lua:97: in function 'open_view_and_draw'                                                                                                             
        ...vim/autoload/plugged/nvim-tree.lua/lua/nvim-tree/lib.lua:123: in function 'open'                                                                                                                          
        ...ig/nvim/autoload/plugged/nvim-tree.lua/lua/nvim-tree.lua:47: in function 'open'                                                                                                                           
        [string ":lua"]:1: in main chunk                  

Problem seems to be in view.lua, the setlocal() function was added to solve this issue

My specs: nvim --version On Ubuntu 18.04.6 LTS x86_64

NVIM v0.6.1
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

with default build config.

-- following options are the default
-- each of these are documented in `:help nvim-tree.OPTION_NAME`
vim.g.nvim_tree_icons = {
  default = "",
  symlink = "",
  git = {
    unstaged = "",
    staged = "S",
    unmerged = "",
    renamed = "➜",
    deleted = "",
    untracked = "U",
    ignored = "◌",
  },
  folder = {
    default = "",
    open = "",
    empty = "",
    empty_open = "",
    symlink = "",
  },
}

local status_ok, nvim_tree = pcall(require, "nvim-tree")
if not status_ok then
  return
end

local config_status_ok, nvim_tree_config = pcall(require, "nvim-tree.config")
if not config_status_ok then
  return
end

nvim_tree.setup{}

[fakeyanss]

Similar issue when calling :NvimTreeToggle

My specs: nvim --version On macOS 12.3 (21E230):

My nvim version
NVIM v0.7.0-dev+1135-gfdea15723
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

with default build config.

require('nvim-tree').setup {
}

[alex-courtis]

Problem seems to be in view.lua, the setlocal() function was added to solve this issue

The upstream issue is complex and does not appear to have been resolved.

setlocal is correctly setting the window option winhl in neovim 0.6.1 and 0.7.0.

Therefore we will not investigate it when diagnosing this bug, unless all other avenues have been exhausted.

E5108: Error executing lua ...im/autoload/plugged/nvim-tree.lua/lua/nvim-tree/view.lua:121: Vim(setlocal):E474: Invalid argument:

This indicates that we are attempting to set the value for a highlight-group that is not built-in. See :help winhl

The simple test :setlocal winhl=AAA:ZZZ demonstrates this, :setlocal winhl=NormalNC:ZZZ does not.

[alex-courtis]

Actions: @tttoad @gulliver-madrid @Marko-Sanchez @fakeyanss :

Execute this and put the results into a file. This will discover the bulit-in highlight groups.

redir @" | silent hi | redir end | let @+ = @"

Execute the following until an error occurs.

:setlocal winhl=EndOfBuffer:NvimTreeEndOfBuffer
:setlocal winhl=Normal:NvimTreeNormal
:setlocal winhl=CursorLine:NvimTreeCursorLine
:setlocal winhl=WinSeparator:NvimTreeWinSeparator
:setlocal winhl=StatusLine:NvimTreeStatusLine
:setlocal winhl=StatusLineNC:NvimTreeStatuslineNC
:setlocal winhl=SignColumn:NvimTreeSignColumn
:setlocal winhl=NormalNC:NvimTreeNormalNC
:setlocal winhl=EndOfBuffer:NvimTreeEndOfBuffer,Normal:NvimTreeNormal,CursorLine:NvimTreeCursorLine,WinSeparator:NvimTreeWinSeparator,StatusLine:NvimTreeStatusLine,StatusLineNC:NvimTreeStatuslineNC,SignColumn:NvimTreeSignColumn,NormalNC:NvimTreeNormalNC

Repeat the above, starting neovim via nvim --clean.

Completed, thank you @anpin : #1221 (comment)

Actions: @alex-courtis :

Depending on the results of the above

• attempt a fix
• create a branch with some diagnostics

[evantancy]

Idk what's going on but setting the commit using vim-plug for 4288981 seems to fix

[anpin]

hi @alex-courtis, I'm on win10 and after running suggested commands I found that E474 occurs at :setlocal winhl=WinSeparator:NvimTreeWinSeparator and :setlocal winhl=EndOfBuffer:NvimTreeEndOfBuffer,Normal:NvimTreeNormal,CursorLine:NvimTreeCursorLine,WinSeparator:NvimTreeWinSeparator,StatusLine:NvimTreeStatusLine,StatusLineNC:NvimTreeStatuslineNC,SignColumn:NvimTreeSignColumn,NormalNC:NvimTreeNormalNC also see the requested output here nvim.txt

[alex-courtis]

I found that E474 occurs at :setlocal winhl=WinSeparator:NvimTreeWinSeparator

That's great, thank you. We can see that the WinSeparator highlight group is definitely not present. This can be investigated.

In the meantime, I might hack together a temporary hacky fix that doesn't set this group if it's not available.