Skip to content

fix(statusline): better window picker highlight #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2022
Merged

fix(statusline): better window picker highlight #1139

merged 2 commits into from
Apr 9, 2022

Conversation

aspeddro
Copy link
Contributor

@aspeddro aspeddro commented Apr 7, 2022 •
edited
Loading

This PR removes highlighting on NvimTree introduced in #1098

Before:
image

After:
image

Other change:

  • Not open file if input char not included in window_picker.chars

@aspeddro aspeddro marked this pull request as draft April 7, 2022 00:37
@aspeddro aspeddro marked this pull request as ready for review April 7, 2022 02:45
@aspeddro aspeddro changed the title fix(statusline): remove window picker highlight fix(statusline): better window picker highlight Apr 7, 2022
alex-courtis
alex-courtis approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand the before / after, as the help is botright in the before.

It all looks good and status line highlighting worked for me.

@aspeddro
Copy link
Contributor Author

aspeddro commented Apr 9, 2022

Not sure I understand the before / after, as the help is botright in the before.

It all looks good and status line highlighting worked for me.

Image updated.

kyazdani42
kyazdani42 approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@kyazdani42 kyazdani42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@kyazdani42 kyazdani42 merged commit deb1f25 into nvim-tree:master Apr 9, 2022
@kyazdani42 kyazdani42 mentioned this pull request Apr 9, 2022
Closed
@aspeddro aspeddro deleted the global-statusline branch April 9, 2022 17:18
Almo7aya pushed a commit to Almo7aya/nvim-tree.lua that referenced this pull request Oct 11, 2022
@aspeddro
fix(statusline): better window picker highlight (nvim-tree#1139)
0211347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-courtis alex-courtis alex-courtis approved these changes

@kyazdani42 kyazdani42 kyazdani42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aspeddro @alex-courtis @kyazdani42