fix: window picker bug on global statusline #1098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyazdani42
approved these changes
Mar 22, 2022
|
Why set the NvimTree status line to blank? This is changing the colors of The version prior to this PR is more consistent with user experience. |
|
thing is, if you go from laststatus 3 to laststatus 2, the bar will appear in nvim-tree in a different way than you are used to be, which would be less consistent imo. The window picker should be a simple "can you select" or "cant you select", not displaying personal buffer information i guess. But maybe this could also be expanded as if the buffer cannot be selected, the statusline display another color that is disabled. |
Almo7aya
pushed a commit
to Almo7aya/nvim-tree.lua
that referenced
this pull request
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #1096.
I set the NvimTree status line to blank when global status is set and window picker is activated. When window picker is deactivated, I restores NvimTree status line to its previous state.
See below screenshots for reference.
Before patch
After patch
