-
-
Notifications
You must be signed in to change notification settings - Fork 51
feature: ci with multiple targets #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You can also take a look at https://github.com/node-oauth/node-oauth2-server/actions/runs/1336376151 |
@jankapunkt you need to target development branch! Not master ;) Also, per this conversation about the linter, we realized that ESLint actually runs a specific version of Node 12 #30 (comment) When we add linting to the pipeline, this will be an issue no doubt. So maybe there's a way to target that specific node version? I guess it doesn't really matter, since it's just a dev dependency for ESLint. |
Hey @HappyZombies my bad, changed. Regarding eslint it runs fine on all three node versions in the ci so I think this should not be a problem, right? |
@jankapunkt I think you are right, I believe the CI uses whatever latest LTS is for Node 12, which is supported for that specific Node version. Thanks, I'll do one final check, then approve and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jankapunkt quick question on the npm run test being removed.
This implements #34 in a way that our CI always tests for multiple node versions. Also removed the old travis file.