Skip to content

[FIX] change fsl interface randomise --f_only to --fonly for #3322 #3325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

henrymj
Copy link
Contributor

@henrymj henrymj commented Apr 9, 2021

Summary

Fixes #3322.

List of changes proposed in this PR (pull-request)

  • corrects typo in fsl randomise interface for running only f-tests.

Acknowledgment

  • [ x] (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #3325 (fe4cf08) into master (6c06030) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3325   +/-   ##
=======================================
  Coverage   65.00%   65.00%           
=======================================
  Files         302      302           
  Lines       40027    40027           
  Branches     5292     5292           
=======================================
  Hits        26021    26021           
  Misses      12934    12934           
  Partials     1072     1072           
Flag Coverage Δ
unittests 64.70% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/fsl/model.py 55.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c06030...fe4cf08. Read the comment docs.

@effigies
Copy link
Member

effigies commented Apr 9, 2021

I can confirm that --fonly is also correct for FSL 5.0.9. Thanks for the contribution!

@effigies effigies merged commit 89d828c into nipy:master Apr 9, 2021
@effigies effigies added this to the 1.6.1 milestone May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fsl randomise f_only flag contains typo, can't work
2 participants