-
Notifications
You must be signed in to change notification settings - Fork 533
ENH: Updates interface for FSL's eddy
command
#3008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Allows fslstats calls with the -K option
Change by @effigies Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Fix/mne watershed bem
TO DOFor For |
mrresize
command and updates interface for FSL's eddy
commandmrresize
command and updates interface for FSL's eddy
command
Codecov Report
@@ Coverage Diff @@
## master #3008 +/- ##
==========================================
- Coverage 67.5% 66.97% -0.53%
==========================================
Files 344 343 -1
Lines 44039 44105 +66
Branches 5554 5560 +6
==========================================
- Hits 29727 29541 -186
- Misses 13560 13806 +246
- Partials 752 758 +6
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3008 +/- ##
==========================================
+ Coverage 67.5% 68.19% +0.69%
==========================================
Files 344 344
Lines 44039 46004 +1965
Branches 5554 6199 +645
==========================================
+ Hits 29727 31374 +1647
- Misses 13560 13827 +267
- Partials 752 803 +51
Continue to review full report at Codecov.
|
FIX: Specify correct stop criterion flag in PETPVC
Co-Authored-By: Oscar Esteban <code@oscaresteban.es>
ENH: replace portalocker with filelock
Prevents nipy#3009 and nipy#3014 from happening - although this might not solve those issues, this patch will help find their origin by making ``load_resultfile`` more strict (and letting it raise exceptions). The try .. except structure is moved to the only place is was being used within the Node code.
FIX: Disallow returning ``None`` in ``pipeline.utils.load_resultfile``
Generating the hashvalue when outputs are not ready at cache check stage when the node's directory does not exist (or no results file is in there) leads to nipy#3014. This PR preempts those problems by delaying the hashval calculation.
Minimize the access to the ``result`` property when writing pre/post-execution reports. This modification should particularly preempt nipy#3009 (comment)
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
ENH: Avoid loading result from file when writing reports
ENH: Lightweight node cache checking
Hi @josephmje sorry for duplicating requests, hopefully git is making it easy for you. Could you split this PR in two? One for the changes in eddy and the other for the new interface? That will make review and investigation of regressions much easier. |
mrresize
command and updates interface for FSL's eddy
commandeddy
command
Summary
Adds a new interface for Mrtrix3's
mrresize
command and updates inputs and outputs for FSL'seddy
commandList of changes proposed in this PR (pull-request)
MRTrix3BaseInputSpec
modified to take eithergrad_file
orgrad_fsl
field
now requires a file instead of stringAcknowledgment