Skip to content

ENH: Add index_mask_file input to ImageStats #3005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2019

Conversation

stilley2
Copy link
Contributor

Summary

Allows fslstats calls with the -K option

List of changes proposed in this PR (pull-request)

  • add an input to ImageStats corresponding to the -K option to fslstats

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #3005 into master will decrease coverage by 17.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #3005       +/-   ##
==========================================
- Coverage   67.47%   50.4%   -17.08%     
==========================================
  Files         344     126      -218     
  Lines       44038   25304    -18734     
  Branches     5554       0     -5554     
==========================================
- Hits        29716   12755    -16961     
+ Misses      13575   12549     -1026     
+ Partials      747       0      -747
Flag Coverage Δ
#smoketests 50.4% <100%> (+0.3%) ⬆️
#unittests ?
Impacted Files Coverage Δ
nipype/interfaces/fsl/utils.py 63.84% <100%> (-6.49%) ⬇️
nipype/workflows/smri/freesurfer/ba_maps.py 11.11% <0%> (-88.89%) ⬇️
nipype/workflows/smri/freesurfer/autorecon3.py 2.43% <0%> (-72.92%) ⬇️
nipype/workflows/smri/freesurfer/autorecon2.py 2.68% <0%> (-72.42%) ⬇️
nipype/workflows/rsfmri/fsl/resting.py 13.11% <0%> (-72.14%) ⬇️
nipype/pipeline/plugins/pbsgraph.py 29.41% <0%> (-64.71%) ⬇️
nipype/workflows/smri/freesurfer/recon.py 9.92% <0%> (-64.54%) ⬇️
nipype/pipeline/plugins/tools.py 23.28% <0%> (-61.65%) ⬇️
nipype/workflows/smri/freesurfer/bem.py 38.46% <0%> (-61.54%) ⬇️
nipype/interfaces/utility/csv.py 42.85% <0%> (-57.15%) ⬇️
... and 286 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7ab9cb...ac54739. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #3005 into master will decrease coverage by 0.49%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3005     +/-   ##
=========================================
- Coverage   67.47%   66.98%   -0.5%     
=========================================
  Files         344      344             
  Lines       44038    44039      +1     
  Branches     5554     5554             
=========================================
- Hits        29716    29500    -216     
- Misses      13575    13759    +184     
- Partials      747      780     +33
Flag Coverage Δ
#smoketests 50.4% <100%> (+0.3%) ⬆️
#unittests 64.35% <100%> (-0.59%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/fsl/utils.py 70.35% <100%> (+0.03%) ⬆️
nipype/pipeline/plugins/oar.py 30.68% <0%> (-23.87%) ⬇️
nipype/interfaces/nipy/base.py 80% <0%> (-20%) ⬇️
nipype/testing/utils.py 72.41% <0%> (-17.25%) ⬇️
nipype/interfaces/dipy/registration.py 83.33% <0%> (-16.67%) ⬇️
nipype/interfaces/dipy/stats.py 83.33% <0%> (-16.67%) ⬇️
nipype/workflows/dmri/fsl/tbss.py 78.37% <0%> (-10.82%) ⬇️
nipype/workflows/smri/freesurfer/ba_maps.py 90.27% <0%> (-9.73%) ⬇️
nipype/interfaces/freesurfer/base.py 71.18% <0%> (-9.33%) ⬇️
nipype/info.py 85.71% <0%> (-8.58%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7ab9cb...22efaf7. Read the comment docs.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this could be improved with a description. I copied the text from fslstats --help, but feel free to write something else.

Change by @effigies

Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
@effigies effigies added this to the 1.2.2 milestone Aug 30, 2019
@effigies
Copy link
Member

Thanks!

@effigies effigies merged commit beefe81 into nipy:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants