Skip to content

Fix broken format_node due to missing inspect import. #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2016

Conversation

mvbnoel
Copy link
Contributor

@mvbnoel mvbnoel commented Jul 5, 2016

I tried to use the export feature of the workflow object, but it kept failing because of the import of the inspect module. The latter was indeed missing. Since inspect is not available for the early Python 3 and Python 2 releases, I also use the funcsigs module which backports the signature function.

I have tested it on my private fork, running Python 2.7 and the export now works. However I could not figure out how to specify the conditional install_requires on funcsigs inside the setup.py. You guys might want to merge this PR as it is and fix the setup.py later, or give me some pointers on how to do it.

cheers.

@coveralls
Copy link

coveralls commented Jul 5, 2016

Coverage Status

Coverage increased (+0.002%) to 72.29% when pulling c518f1b on mvbnoel:fix/format-node-missing-import into 3f336b4 on nipy:master.

@satra
Copy link
Member

satra commented Jul 12, 2016

@mvbnoel - we only support 2.7, 3.3+ - so this fix should work.

@satra satra merged commit 834a298 into nipy:master Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants