NH-3905 - upgrade async generator and regen

Tools/packages.config

@@ -7,6 +7,6 @@
   <package id="NUnit.Extension.NUnitV2ResultWriter" version="3.6.0" targetFramework="net461" />
   <package id="NUnit.Extension.TeamCityEventListener" version="1.0.2" targetFramework="net461" />
   <package id="NUnit.Extension.VSProjectLoader" version="3.6.0" targetFramework="net461" />
-  <package id="CSharpAsyncGenerator.CommandLine" version="0.4.4" targetFramework="net461" />
+  <package id="CSharpAsyncGenerator.CommandLine" version="0.5.0" targetFramework="net461" />
   <package id="vswhere" version="2.1.4" targetFramework="net461" />
 </packages>

doc/reference/modules/quickstart.xml

@@ -420,6 +420,12 @@ finally
             cases.
         </para>
 
+        <para>
+            Since NHibernate 5.0, the session and its queries IO bound methods have async counterparts.
+            Each call to an async method must be awaited before further interacting with the session or
+            its queries.
+        </para>
+
     </sect1>
 
     <sect1 id="quickstart-summary">

doc/reference/modules/transactions.xml

@@ -93,6 +93,11 @@
                     Never access the same <literal>ISession</literal> in two concurrent threads.
                     An <literal>ISession</literal> is usually only a single unit-of-work!
                 </para>
+                <para>
+                    Since NHibernate 5.0, the session and its queries IO bound methods have async counterparts.
+                    Each call to an async method must be awaited before further interacting with the session or
+                    its queries.
+                </para>
             </listitem>
         </itemizedlist>
     </sect1>

src/AsyncGenerator.yml

@@ -184,8 +184,6 @@
     - hasAttributeName: TestAttribute
     - hasAttributeName: TheoryAttribute
     typeConversion:
-    - conversion: Ignore
-      name: NorthwindDbCreator
     - conversion: Ignore
       name: ObjectAssert
     - conversion: Ignore
@@ -200,9 +198,13 @@
       rule: IsTestCase
     - conversion: Ignore
       anyBaseTypeRule: IsTestCase
+    ignoreSearchForMethodReferences:
+    - hasAttributeName: TheoryAttribute
+    - hasAttributeName: TestAttribute
     ignoreDocuments:
     - filePathEndsWith: Linq\MathTests.cs
     - filePathEndsWith: Linq\ExpressionSessionLeakTest.cs
+    - filePathEndsWith: Linq\NorthwindDbCreator.cs
     cancellationTokens:
       withoutCancellationToken:
       - hasAttributeName: TestAttribute

src/NHibernate.DomainModel/Async/CustomPersister.cs

@@ -26,9 +26,6 @@ namespace NHibernate.DomainModel
 {
 	using System.Threading.Tasks;
 	using System.Threading;
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class CustomPersister : IEntityPersister
 	{
 

src/NHibernate.Test/Async/ConnectionStringTest/NamedConnectionStringFixture.cs

@@ -20,9 +20,6 @@ namespace NHibernate.Test.ConnectionStringTest
 	using System.Threading.Tasks;
 	using System.Threading;
 
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class MockConnectionProvider : ConnectionProvider
 	{
 

src/NHibernate.Test/Async/DebugConnectionProvider.cs

@@ -19,9 +19,6 @@ namespace NHibernate.Test
 {
 	using System.Threading.Tasks;
 	using System.Threading;
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class DebugConnectionProvider : DriverConnectionProvider
 	{
 

src/NHibernate.Test/Async/DebugSessionFactory.cs

@@ -37,9 +37,6 @@ namespace NHibernate.Test
 {
 	using System.Threading.Tasks;
 	using System.Threading;
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class DebugSessionFactory : ISessionFactoryImplementor
 	{
 

src/NHibernate.Test/Async/DynamicProxyTests/PeVerifier.cs

@@ -16,11 +16,6 @@
 namespace NHibernate.Test.DynamicProxyTests
 {
 	using System.Threading.Tasks;
-
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
-
 	public partial class PeVerifier
 	{
 

src/NHibernate.Test/Async/Events/Collections/CollectionListeners.cs

@@ -17,9 +17,6 @@
 
 namespace NHibernate.Test.Events.Collections
 {
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class CollectionListeners
 	{
 
@@ -32,9 +29,6 @@ public partial class CollectionListeners
 
 		#region Nested type: InitializeCollectionListener
 
-		/// <content>
-		/// Contains generated async methods
-		/// </content>
 		public partial class InitializeCollectionListener : DefaultInitializeCollectionEventListener, IListener
 		{
 
@@ -53,9 +47,6 @@ public override async Task OnInitializeCollectionAsync(InitializeCollectionEvent
 
 		#region Nested type: PostCollectionRecreateListener
 
-		/// <content>
-		/// Contains generated async methods
-		/// </content>
 		public partial class PostCollectionRecreateListener : AbstractListener, IPostCollectionRecreateEventListener
 		{
 
@@ -81,9 +72,6 @@ public Task OnPostRecreateCollectionAsync(PostCollectionRecreateEvent @event, Ca
 
 		#region Nested type: PostCollectionRemoveListener
 
-		/// <content>
-		/// Contains generated async methods
-		/// </content>
 		public partial class PostCollectionRemoveListener : AbstractListener, IPostCollectionRemoveEventListener
 		{
 
@@ -109,9 +97,6 @@ public Task OnPostRemoveCollectionAsync(PostCollectionRemoveEvent @event, Cancel
 
 		#region Nested type: PostCollectionUpdateListener
 
-		/// <content>
-		/// Contains generated async methods
-		/// </content>
 		public partial class PostCollectionUpdateListener : AbstractListener, IPostCollectionUpdateEventListener
 		{
 
@@ -137,9 +122,6 @@ public Task OnPostUpdateCollectionAsync(PostCollectionUpdateEvent @event, Cancel
 
 		#region Nested type: PreCollectionRecreateListener
 
-		/// <content>
-		/// Contains generated async methods
-		/// </content>
 		public partial class PreCollectionRecreateListener : AbstractListener, IPreCollectionRecreateEventListener
 		{
 
@@ -165,9 +147,6 @@ public Task OnPreRecreateCollectionAsync(PreCollectionRecreateEvent @event, Canc
 
 		#region Nested type: PreCollectionRemoveListener
 
-		/// <content>
-		/// Contains generated async methods
-		/// </content>
 		public partial class PreCollectionRemoveListener : AbstractListener, IPreCollectionRemoveEventListener
 		{
 
@@ -193,9 +172,6 @@ public Task OnPreRemoveCollectionAsync(PreCollectionRemoveEvent @event, Cancella
 
 		#region Nested type: PreCollectionUpdateListener
 
-		/// <content>
-		/// Contains generated async methods
-		/// </content>
 		public partial class PreCollectionUpdateListener : AbstractListener, IPreCollectionUpdateEventListener
 		{
 

src/NHibernate.Test/Async/Events/DisposableListenersTest.cs

@@ -17,9 +17,6 @@ namespace NHibernate.Test.Events
 {
 	using System.Threading.Tasks;
 	using System.Threading;
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class MyDisposableListener : IPostUpdateEventListener, IDisposable
 	{
 		public Task OnPostUpdateAsync(PostUpdateEvent @event, CancellationToken cancellationToken)

src/NHibernate.Test/Async/Events/PostEvents/AssertOldStatePostListener.cs

@@ -16,9 +16,6 @@ namespace NHibernate.Test.Events.PostEvents
 	using System.Threading.Tasks;
 	using System.Threading;
 
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class AssertOldStatePostListener : IPostUpdateEventListener
 	{
 

src/NHibernate.Test/Async/IdGen/Enhanced/SourceMock.cs

@@ -14,9 +14,6 @@ namespace NHibernate.Test.IdGen.Enhanced
 {
 	using System.Threading.Tasks;
 	using System.Threading;
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class SourceMock : IAccessCallback
 	{
 

src/NHibernate.Test/Async/Insertordering/InsertOrderingFixture.cs

@@ -677,9 +677,6 @@ public IBatcher CreateBatcher(ConnectionManager connectionManager, IInterceptor
 
 		#endregion
 	}
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class InsertOrderingFixture : TestCase
 	{
 
@@ -695,9 +692,6 @@ public partial class InsertOrderingFixture : TestCase
 
 
 
-		/// <content>
-		/// Contains generated async methods
-		/// </content>
 		public partial class StatsBatcher : SqlClientBatchingBatcher
 		{
 

src/NHibernate.Test/Async/Linq/ObjectDumper.cs

@@ -17,9 +17,6 @@
 namespace NHibernate.Test.Linq
 {
 	using System.Threading.Tasks;
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class ObjectDumper
 	{
 

src/NHibernate.Test/Async/Linq/QueryTimeoutTests.cs

@@ -141,16 +141,10 @@ public IBatcher CreateBatcher(ConnectionManager connectionManager, IInterceptor
 			}
 		}
 	}
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class QueryTimeoutTests : LinqTestCase
 	{
 
 
-		/// <content>
-		/// Contains generated async methods
-		/// </content>
 		public partial class TimeoutCatchingNonBatchingBatcher : NonBatchingBatcher
 		{
 

src/NHibernate.Test/Async/NHSpecificTest/NH1054/DummyTransactionFactory.cs

@@ -18,9 +18,6 @@ namespace NHibernate.Test.NHSpecificTest.NH1054
 {
 	using System.Threading.Tasks;
 	using System.Threading;
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class DummyTransactionFactory : ITransactionFactory
 	{
 

src/NHibernate.Test/Async/NHSpecificTest/NH1230/PreSaveDoVeto.cs

@@ -15,9 +15,6 @@ namespace NHibernate.Test.NHSpecificTest.NH1230
 {
 	using System.Threading.Tasks;
 	using System.Threading;
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class PreSaveDoVeto : IPreInsertEventListener
 	{
 

src/NHibernate.Test/Async/NHSpecificTest/NH1270/Fixture.cs

@@ -18,7 +18,6 @@
 namespace NHibernate.Test.NHSpecificTest.NH1270
 {
 	using System.Threading.Tasks;
-	using System.Threading;
 	[TestFixture]
 	public class FixtureAsync
 	{

src/NHibernate.Test/Async/NHSpecificTest/NH1274ExportExclude/NH1274ExportExcludeFixture.cs

@@ -22,7 +22,6 @@
 namespace NHibernate.Test.NHSpecificTest.NH1274ExportExclude
 {
 	using System.Threading.Tasks;
-	using System.Threading;
 	[TestFixture]
 	public class NH1274ExportExcludeFixtureAsync
 	{

src/NHibernate.Test/Async/NHSpecificTest/NH1332/Fixture.cs

@@ -80,15 +80,9 @@ public void OnPostDelete(PostDeleteEvent @event)
 			}
 		}
 	}
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class Fixture : BugTestCase
 	{
 
-		/// <content>
-		/// Contains generated async methods
-		/// </content>
 		public partial class PostCommitDelete : IPostDeleteEventListener
 		{
 			public Task OnPostDeleteAsync(PostDeleteEvent @event, CancellationToken cancellationToken)

src/NHibernate.Test/Async/NHSpecificTest/NH1487/Fixture.cs

@@ -18,7 +18,6 @@
 namespace NHibernate.Test.NHSpecificTest.NH1487
 {
 	using System.Threading.Tasks;
-	using System.Threading;
 
 	/// <summary>
 	/// Summary description for TestTestCase.

src/NHibernate.Test/Async/NHSpecificTest/NH1714/UseCaseDemonstrationFixture.cs

@@ -64,9 +64,6 @@ public async Task DbCommandsFromEventListenerShouldBeEnlistedInRunningTransactio
 		}
 	}
 
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class MyCustomEventListener : IPreInsertEventListener
 	{
 		public async Task<bool> OnPreInsertAsync(PreInsertEvent e, CancellationToken cancellationToken)

src/NHibernate.Test/Async/NHSpecificTest/NH1789/DomainObject.cs

@@ -15,9 +15,6 @@ namespace NHibernate.Test.NHSpecificTest.NH1789
 {
 	using System.Threading.Tasks;
 	using System.Threading;
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public abstract partial class DomainObject : IDomainObject
 	{
 

src/NHibernate.Test/Async/NHSpecificTest/NH1882/TestCollectionInitializingDuringFlush.cs

@@ -155,15 +155,9 @@ public async Task TestInitializationDuringFlushAsync()
 			Assert.That(listener.FoundAny, Is.True);
 		}
 	}
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class TestCollectionInitializingDuringFlush : TestCaseMappingByCode
 	{
 
-		/// <content>
-		/// Contains generated async methods
-		/// </content>
 		public partial class InitializingPreUpdateEventListener : IPreUpdateEventListener
 		{
 

src/NHibernate.Test/Async/NHSpecificTest/NH2322/PostUpdateEventListener.cs

@@ -17,9 +17,6 @@ namespace NHibernate.Test.NHSpecificTest.NH2322
 {
 	using System.Threading.Tasks;
 	using System.Threading;
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class PostUpdateEventListener : IPostUpdateEventListener
 	{
 		Task IPostUpdateEventListener.OnPostUpdateAsync(PostUpdateEvent @event, CancellationToken cancellationToken)

src/NHibernate.Test/Async/NHSpecificTest/NH2583/Domain.cs

@@ -14,9 +14,6 @@ namespace NHibernate.Test.NHSpecificTest.NH2583
 {
     using System.Threading.Tasks;
     using System.Threading;
-    /// <content>
-    /// Contains generated async methods
-    /// </content>
     public partial class MyRef1
     {
 
@@ -41,9 +38,6 @@ public partial class MyRef1
         }
     }
 
-    /// <content>
-    /// Contains generated async methods
-    /// </content>
     public partial class MyBO
     {