NH-3905 - upgrade async generator and regen #692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes <content> generated comments which sometimes interfere with some tooling (Rider), and clean some undue generated imports.
fredericDelaporte
force-pushed
the
NH-3905
branch
from
80c9c8f to
4bdd6cb
Compare
hazzik
previously approved these changes
Sep 19, 2017
|
Hi-jacked this PR for dropping a note on async in documentation. (I will not squash commits together.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up generation by 30%, removes generated comments which sometimes interfere with some tooling (Rider), and clean some undue generated imports.
The comment removal (maca88/AsyncGenerator#55) is responsible of most changes, while some async test files also have some undue
import System.Threadingremoved (maca88/AsyncGenerator#51).